git-pretty-pull-request's People
Forkers
eliasinho aleblondin phacks martingtheodo emnak clementhannicq jeandlv adriencaccia pallavirishi baptistg abdeladel antoineeudes camilalopesgit-pretty-pull-request's Issues
Use the preferred file editor configured in git?
Something like EDITOR=$(git config --get core.editor)
Ignore title in markdown
Hi @williamdclt
I found a bug in gppr: when your PULL_REQUEST_TEMPLATE
contains markdown headers (with #
) it interprets it as a comment and it is stripped from the real pull request message.
Nested lists do not work in PR templates
Hi @williamdclt!
Just noticed a small bug in the way PR templates are handled in pretty-pull-request
.
The following template in PULL_REQUEST_TEMPLATE.md
:
- [ ] The Definition of Done is respected:
- [ ] IE 11
- [ ] Chrome latest
is rendered in GitHub:
- [ ] The Definition of Done is respected:
- [ ] IE 11
- [ ] Chrome latest
Meaning we’re losing the nested list feature in markdown.
I think the issue comes from these two lines:
git-pretty-pull-request/git-pretty-pull-request
Lines 136 to 137 in 119c15f
I could try and give it a go on my own, although if you happen to know exactly what the problem is and can help me submit a PR, that’d be awesome!
Thanks,
Nicolas
No fail if a prepush hook fails
If the project has prepush hooks (such as the ones done with Husky), this will not fail:
git commit -m "Something wrong with new ESLint errors"
git pretty-pull-request // includes code-pushing
And 🎉 there is a commit that fails the tests pushed to the repo 🙂
I think the expected behavior is to git push
before git pr
but you can miss it
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.