williamdclt / git-pretty-pull-request Goto Github PK

Something like EDITOR=$(git config --get core.editor)

Hi @williamdclt

I found a bug in gppr: when your PULL_REQUEST_TEMPLATE contains markdown headers (with # ) it interprets it as a comment and it is stripped from the real pull request message.

Hi @williamdclt!

Just noticed a small bug in the way PR templates are handled in pretty-pull-request.

The following template in PULL_REQUEST_TEMPLATE.md:

- [ ] The Definition of Done is respected:
  - [ ] IE 11
  - [ ] Chrome latest

is rendered in GitHub:

- [ ] The Definition of Done is respected:
- [ ] IE 11
- [ ] Chrome latest

Meaning we’re losing the nested list feature in markdown.

I think the issue comes from these two lines:

I could try and give it a go on my own, although if you happen to know exactly what the problem is and can help me submit a PR, that’d be awesome!

Thanks,

Nicolas

If the project has prepush hooks (such as the ones done with Husky), this will not fail:

git commit -m "Something wrong with new ESLint errors"
git pretty-pull-request // includes code-pushing

And 🎉 there is a commit that fails the tests pushed to the repo 🙂

I think the expected behavior is to git push before git pr but you can miss it