In line 106

  _expiresToDateTime(expires) {
    if (typeof expires === 'number') {
      const duration = moment.duration(expires, 'days')
      const ms = duration.asMilliseconds()
      return moment()
        .add(ms, 'ms')
        .format()
    } else {
      moment(expires).format()  /* should return here */
    }
  }

Consider using typescript, that would have picked up this bug quite easily.

Hello everyone!

This library is not working in the IE 11. Because the main file includes ES6 syntax.

• Lib
• Docs

Hi @will-stone, thanks for the great work providing a reactive cookie for mobx with mobx-cookie.

Recently, I ran through the code as I need to provide a Typescript definition for this library (we have to use Typescript at work). And there is a minor thing I reckon we can do.

class MobxCookie {
  /**
   * @param {*} name cookie's name
   * @param {*} options (optional) options to send to js-cookie
   */
  constructor(name, options) {
    this.name = name // name of set cookie
    this.options = options // options to send to js-cookie
    this._timeout = null // internal timer

    extendObservable(this, {
      value: jsCookie.get(name) // observable to keep in-sync with cookie value
    })

    this._syncTimeout()
  }

Our constructor is currently accepting a second parameter as js-cookie options. However, I don't think we use this.options anywhere, instead, if someone want to set the option, he/she needs to do it everytime set function is called.

I reckon there are two separated ways we can improve this:

1.) Drop options as the second parameter of the constructor.

2.) set function will make use of this.options if no options param is passed to this function, if there is an options param passed, it will be merged and overriden the class options.

What do you think ? I am happy to submit a PR for this issue.

Does mobx-cookie have any issue with mobx v5? If not, it would be good to update the peer dependency to allow it.

Hi guys,
I've been trying to make a login function where a request is send to a Drupal backend and returns the users data + cookie session etc.

Now I have been testing it with Postman, which works just fine. The cookie is stored in the browsers (when i check with dev tools and browser settings). But, whenever I make the same request with axios and using the cookie-mobx library the data it returns is correctly. Then I try to store the cookie, that is visible in the devtools application but not in the browser settings.

What am I missing? I am using the same template-example from mobx-cookie.

import Cookie from 'mobx-cookie';

import User from '../interfaces/User';

type SetUserHandler = (user: User) => void;

interface SessionStore {
  user: User;
  setUser: SetUserHandler;
}

class SessionStoreImpl implements SessionStore {
  cookie = new Cookie("user");

  setUser(user: User) {
    this.cookie.set(user);
  }

  get user() {
    return this.cookie.value;
  }
}

export default SessionStoreImpl;

Not able to set user in cookie, it expects a string