wildfly-extras / wildfly-datasources-galleon-pack Goto Github PK

View Code? Open in Web Editor NEW

21.0 21.0 18.0 478 KB

WildFly Feature Pack for DataSources

License: Apache License 2.0

Java 100.00%

wildfly-datasources-galleon-pack's People

Contributors

Stargazers

Watchers

Forkers

jfdenise yersan ochaloup g-ork jamesjr123 codylerum jmesnil vi1234sh12 rissingh1281 eirisdg jamezp pferraro livebythecode fabiobrz robert0714 weltonrodrigo bstansberry kabir

wildfly-datasources-galleon-pack's Issues

MySQL driver GAV has changed

https://blogs.oracle.com/mysql/post/mysql-connectorj-has-new-maven-coordinates

This project now uses 8.0.30 version https://github.com/wildfly-extras/wildfly-datasources-galleon-pack/blob/main/pom.xml#L50 but as soon as this gets updated, the warning will appear in maven build:

[WARNING] The artifact mysql:mysql-connector-java:jar:8.0.31 has been relocated to com.mysql:mysql-connector-j:jar:8.0.31: MySQL Connector/J artifacts moved to reverse-DNS compliant Maven 2+ coordinates.

They claim to keep the old GAV up for some time but better to change that soon.

Document the existence of default variants for the datasource galleon layers

For example, for PostgreSQL galleon layers, the following galleon layer is not documented:

postgresql-default-datasource

eature-pack get-info failing - Resolving feature-pack org.wildfly.core:wildfly-core-galleon-pack:11.0.2.Final-redhat-00001Error: Retrieve info failed.

It seemed additional repositories are needed to use this feature-pack.

[bin]$ feature-pack get-info  org.wildfly:wildfly-datasources-galleon-pack:1.0.7.CD.Final  --type=all
Resolving feature-pack org.wildfly.core:wildfly-core-galleon-pack:11.0.2.Final-redhat-00001Error: Retrieve info failed.
 * Failed to resolve org.wildfly.core:wildfly-core-galleon-pack:zip:11.0.2.Final-redhat-00001
  * Could not find artifact org.wildfly.core:wildfly-core-galleon-pack:zip:11.0.2.Final-redhat-00001 in maven-central (https://repo1.maven.org/maven2/)
   * Could not find artifact org.wildfly.core:wildfly-core-galleon-pack:zip:11.0.2.Final-redhat-00001 in maven-central (https://repo1.maven.org/maven2/)
[bin]$ maven get-info 
======================= ============================================================== 
Configuration Item      Value                                                          
======================= ============================================================== 
Default release policy  daily                                                          
Default snapshot policy never                                                          
Enable release          true                                                           
Enable snapshot         false                                                          
Local repository        /opt/jee/galleon/maven/repo                                    
Maven xml settings      No settings file set                                           
Offline                 false                                                          
Remote repositories     maven-central 
                         url=https://repo1.maven.org/maven2/ 
                         type=default 
                         release=true 
                         releaseUpdatePolicy=daily 
                         snapshot=false 
                         snapshotUpdatePolicy=never 
                        jboss-public-repository-group 
                         url=https://repository.jboss.org/nexus/content/groups/public/ 
                         type=default 
                         release=true 
                         releaseUpdatePolicy=daily 
                         snapshot=false 
                         snapshotUpdatePolicy=never 
                        jboss-ga 
                         url=https://maven.repository.redhat.com/ga/ 
                         type=default 
                         release=true 
                         releaseUpdatePolicy=daily 
                         snapshot=false 
                         snapshotUpdatePolicy=never 


[bin]$

Add new datasource parameter for the attribute 'idle-timeout-minutes'

Hello,

Firewall timeout for idle-connections may sever a connection. This can cause JDBC applications to hang while waiting for a connection.
For these scenarios the attribute idle-timeout-minutes is usually used.

If i'm not mistaken i think this is currently not supported.

Thanks for your time.

Documentation (README) improvements

I believe the various README.md files are the basic documentation for this software. Some suggestions:

More content on the top level README about how to use these, e.g. a simple discussion of what a Galleon feature pack is, links to other content (e.g. some of the WildFly installation guides and general Galleon docs content) and a discussion of what base feature pack(s) the FPs from this project are meant to work with.
Mention of common architectural points, i.e. that for each database type the FP provides 3 Galleon layers that build upon each other -- one just to add the driver, one that builds on the first to add a datasource, one that builds on the second to make the datasource the Jakarta EE default datasource.
In the Datasources section a bit of an intro paragraph that explains that the linked READMEs provide info about how to use the FP to work with each of the listed drivers. Currently it's just driver names that are links but I have no idea what to expect if I click on the link.

Need help in how to configure datasource in wildfly bootable jar

Hello,

I am setting up wildfly bootable jar and wanted to configure a datasource. Looking out for some examples oon how to configure this.

Thanks for your help.

MariaDB driver needs to be dependent on slf4j when deployed as a module 5 of 106 Previous Issue'JBEAP-25038' Next Issue'JBEAP-25035' Return to search

From https://issues.redhat.com/browse/JBEAP-25036:

Since driver version 3.0 MariaDB introduced new logging system to the driver that is based on Slf4j. This dependency is optional, but in case that the slf4j classes aren't available, the log messages are written to stderr which are then caught up by EAP and logged as ERROR even though it should be for example WARN.
The code can be seen here: https://github.com/mariadb-corporation/mariadb-connector-j/blob/master/src/main/java/org/mariadb/jdbc/util/log/Loggers.java#LL98C52-L98C52

To avoid this problem the jdbc driver module should have the dependency to org.slf4j module.

Depend on wildfly-ee galleon pack

Shouldn't this depend on wildfly-ee and not wildfly? It doesn't need any of the MP stuff.

Add a labeler GitHub action

Allow use with wildfly-preview

It would be very useful if wildfly-datasources-galleon-pack could be used with wildfly-preview.

Perhaps wildfly-datasources-galleon-pack does not need to reference or depend on wildfly-ee-galleon-pack which targets EE 8? Or, perhaps a parallel wildfly-preview-datasources-galleon-pack is needed? Or, perhaps there could be a preview flavor that could be referenced with a maven classifier?

Also, thank you for creating and maintaining this wildfly-datasources-galleon-pack. It works very nicely with the wildfly-jar-maven-plugin and this galleon-pack together the wildfly-jar:dev-watch makes for a nice developer experience. The combination, I think, will be very helpful in preparing for Jakarta 10 and even sooner in targeting applications for Jakarta 9.1 on WildFly.

From:
<version.com.oracle.ojdbc8>19.3.0.0</version.com.oracle.ojdbc8>

        <dependency>
            <groupId>com.oracle.ojdbc</groupId>
            <artifactId>ojdbc8</artifactId>
            <version>${version.com.oracle.ojdbc8}</version>
        </dependency>

To:

            <dependency>
                <groupId>com.oracle.database.jdbc</groupId>
                <artifactId>ojdbc8</artifactId>
                <version>21.5.0.0</version>
                <scope>provided</scope>
            </dependency>

Revisit driver modules dependencies

JDBC request fails with "WFLYJPA0060: Transaction is required to perform this operation (either use a transaction or extended persistence context)"

Using the env vars:

  - name: POSTGRESQL_DATABASE
    valueFrom:
      secretKeyRef:
        key: database-name
        name: kitchensink-db
  - name: POSTGRESQL_USER
    valueFrom:
      secretKeyRef:
        key: database-user
        name: kitchensink-db
  - name: POSTGRESQL_PASSWORD
    valueFrom:
      secretKeyRef:
        key: database-password
        name: kitchensink-db
  - name: POSTGRESQL_DATASOURCE
    value: KitchensinkQuickstartDS
  - name: POSTGRESQL_SERVICE_HOST
    value: kitchensink-db
  - name: POSTGRESQL_SERVICE_PORT
    value: "5432"

The same application works when I'm using the env vars to install PostgreSQL driver provided by the WildFly S2I images:

  - name: DATASOURCES
    value: PGSQL
  - name: PGSQL_DATABASE
    valueFrom:
      secretKeyRef:
        key: database-name
        name: kitchensink-db
  - name: PGSQL_USERNAME
    valueFrom:
      secretKeyRef:
        key: database-user
        name: kitchensink-db
  - name: PGSQL_PASSWORD
    valueFrom:
      secretKeyRef:
        key: database-password
        name: kitchensink-db
  - name: PGSQL_DRIVER
    value: postgres
  - name: PGSQL_JNDI
    value: java:jboss/datasources/KitchensinkQuickstartDS
  - name: PGSQL_JTA
    value: "false"
  - name: PGSQL_NONXA
    value: "true"
  - name: PGSQL_URL
    value: "jdbc:postgresql://kitchensink-db:5432/kitchensink"

At first glance, I'm missing the ability to configure JTA (and NONXA) attributes

I've not found which env vars I could use to configure it in either https://github.com/wildfly-extras/wildfly-datasources-galleon-pack/blob/master/src/main/resources/layers/standalone/postgresql-datasource/layer-spec.xml or https://github.com/wildfly-extras/wildfly-datasources-galleon-pack/blob/master/src/main/resources/layers/standalone/postgresql-driver/layer-spec.xml

Improve community experience

Need contributing, code of conduct, security, codeowners.