Hi,
The binFile name is actually husky-php and not husky

vendor/ccinn/husky-php/husky-php

php vendor/ccinn/husky-php/husky-php husky:run pre-commit


 [INFO] husky > pre-commit


husky-php-pre-commit

Hello @whiteCcinn
Thanks for your amazing work! I have ideas on how to evolve and improve the library:

• Dockerized container with different versions of PHP 8.X
• Testing via PHPUnit
• CI/CD via Github Actions
• Symfony 6.x support
• Typing

Would you like to receive PR?

Best regards

Im trying to use this package with Magento 2.4.5 but get the following error:

ccinn/husky-php v0.3.1 requires symfony/filesystem ^3.4|^4|^5 -> found symfony/filesystem[v3.4.0, ..., v3.4.47, v4.0.0, ..., v4.4.42, v5.0.0, ..., v5.4.13] but the package is fixed to v6.1.5 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

Getting error below when I try to install using: composer require --dev ccinn/composer-husky-plugin ccinn/husky-php

I think it might be my PHP version (8.2).

Anyway, this fixes it (added [ ] brackets around variable):

I don't know the process here and I'm new to PHP but I could do a PR if that's ok?

Hi @whiteCcinn

I'm looking at this part of the library and it's currently just a hardcoded sh script. how about if we replace it with a .tpl file? A bit like they are used in the Symfony maker bundle.

WDYT?

I want to change the behavior of the pre-commit hook, but no matter what I put in my .huskyrc file, it always runs the default pre-commit script.

I started digging into it and I think its due to this:

if (json_last_error() === JSON_ERROR_NONE) {
  $this->conf = array_merge($this->conf, $userConf);
}

The documentation states that the huskyrc file should look like this:

{
  "husky": {
    "hooks": {
      "post-merge": "composer install --no-dev",
      "pre-commit": "echo 'test'"
    }
  }
}

But the default is stored like this:

protected $conf = [
        'hooks' => [
            'pre-commit' => 'husky-default-pre-commit',
        ]
    ];

So the resulting array that the RunServices::execute method loops over looks like this:

Array
(
    [hooks] => Array
        (
            [pre-commit] => vendor/ccinn/husky-php/sh/husky-default-pre-commit
        )

    [husky] => Array
        (
            [hooks] => Array
                (
                    [post-merge] => composer install --no-dev
                    [pre-commit] => echo 'test'
                )

        )

)

I'm looking for clarification on which way is correct. If the documentation should just be updated or if we should fix the package

Using with PHP 7.4 produces the following message:

"PHP needs to be a minimum version of PHP 5.6.0 and maximum version of PHP 7.3.*."