Comments (4)
Woooo! This is a REALLY useful issue!! Thank you @Islast! ✨
I'm happy to discuss any refactoring that's needed. I have to admit that I don't really know the benefits of having class methods 😬. The most important thing for me with this refactoring is that the values are written out in a standard form (csv
for example) so that the other commands can be run without running this one.
from scona.
The value of having something saved as a class attribute instead of as a global namespace variable or in a dictionary is that they are easier to identify. i.e if you want to find the nodal partition you calculated for a given graph G
, you only need to type G.nodal_partition
.
The value of class methods is that grammatically you expect nodal_partition(G)
to return a nodal partition, while you expect G.nodal_partition()
to return nothing and make changes to G
. This means that if we want the nodal partition to be saved automatically as an class attribute, G.nodal_partition()
is the better choice.
I think it's good to provide functions in terms of both: normal functions for when you just want to return the result, and class methods for when you want to automatically add to the graph attributes.
BUT, I don't know how adding new class methods to an existing class interferes with it (adding attributes is fine).
from scona.
@kirstie, let me know where and when and what you would like to see written to disk 🌺
from scona.
Completed in #74
from scona.
Related Issues (20)
- Add padding to the colorbar at the bottom HOT 3
- calculate_nodal_measures doesn't work on graph bundles HOT 1
- Pad random graphs with 0s so they are in the right order HOT 4
- Set seed for Erdos Renyi graph in plot degree distribution HOT 4
- Include small world in plot_network_measures HOT 3
- Which version of nilearn do we need? HOT 1
- Cut covars columns from residuals matrix HOT 1
- feature request: tell brainbundle the total number of brains you want
- Catch error if name of graph doesn't exist in brain bundle for plot_rich_club HOT 4
- Adjust legend of plot_rich_club HOT 3
- small_world calculations HOT 1
- Nodal measures for plotting with nilearn HOT 5
- Plots of brains in plotting anatomical network HOT 2
- View Connectome with nilearn HOT 5
- Error with nilearn.plot_connectome HOT 1
- Test for visualisations HOT 1
- Removing old viz modules
- View_corr_mat() - make new || leave old HOT 5
- Make new get_anatomical_layouts() function HOT 1
- Two similar tutorials HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scona.