Refactor the network_analysis_from_corrmat wrapper about scona HOT 4 OPEN

Woooo! This is a REALLY useful issue!! Thank you @Islast! ✨

I'm happy to discuss any refactoring that's needed. I have to admit that I don't really know the benefits of having class methods 😬. The most important thing for me with this refactoring is that the values are written out in a standard form (csv for example) so that the other commands can be run without running this one.

from scona.

The value of having something saved as a class attribute instead of as a global namespace variable or in a dictionary is that they are easier to identify. i.e if you want to find the nodal partition you calculated for a given graph G, you only need to type G.nodal_partition.
The value of class methods is that grammatically you expect nodal_partition(G) to return a nodal partition, while you expect G.nodal_partition() to return nothing and make changes to G. This means that if we want the nodal partition to be saved automatically as an class attribute, G.nodal_partition() is the better choice.
I think it's good to provide functions in terms of both: normal functions for when you just want to return the result, and class methods for when you want to automatically add to the graph attributes.
BUT, I don't know how adding new class methods to an existing class interferes with it (adding attributes is fine).

resources for this
more

from scona.

@kirstie, let me know where and when and what you would like to see written to disk 🌺

from scona.

Completed in #74

from scona.