while-true-do / ansible-role-repo-collabora-code Goto Github PK
View Code? Open in Web Editor NEWA role that installs the yum repository for Collabora Online - CODE from official collaboraoffice.com
License: BSD 3-Clause "New" or "Revised" License
A role that installs the yum repository for Collabora Online - CODE from official collaboraoffice.com
License: BSD 3-Clause "New" or "Revised" License
Question/Enhancement
A repofile is not used.
A repofile should be used from upstream.
I wasnt able to find one. Is it true that there is none? oO
Enhancement
The following code is present in centos.yml
- name: set fact for task names to Add
set_fact:
wtd_repo_collabora_code_task_name: "Add"
when: wtd_repo_collabora_code_state == "present"
- name: set fact for task names to Remove
set_fact:
wtd_repo_collabora_code_task_name: "Remove"
when: wtd_repo_collabora_code_state != "present"
As far as I can see, it is only used some line later
- name: "{{ wtd_repo_collabora_code_task_name }} key for repository Collabora Online CODE"
...
- name: "{{ wtd_repo_collabora_code_task_name }} repository Collabora Online CODE"
Seems like a lot of overhead for a simple wording.
Remove the wtd_repo_collabora_code_task_name
Change the lines to something like
- name: Set repository key for Collabora Online CODE to "{{ wtd_repo_collabora_code_state }}"
...
- name: Set repository for Collabora Online CODE to "{{ wtd_repo_collabora_code_state }}"
Would be much easier to read ( code wise ) and reduce the overhead of setting facts.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.