wfehr / django-time-wizard Goto Github PK

Setup validation on model creation.

For example currently you can create an AbsolutePeriodModel with empty settings.

Depends on django-polymorphic/django-polymorphic#379.

• essential:

  • rename AbsolutePeriodModel to AbsoluteRangePeriodModel
  • remove Model-suffix on models

• nice-to-have:

  • provide release with backward compatibility, e.g. other projects can still import models with their old name

Currently the choices are added as "Field.choices" from given settings which results in migrations if the settings are overridden.
(or if holidays is updated and new countries are added for example)

If the choices are dynamic and not fixed on model-creation, this would not be the case.

Check if the project can be used with the latest django release.

GenericRelations lead often to problems and are most of the time unnecessary.
Those should be remove.

The manage.py in your repo is broken.
The following line does not work:
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "test/settings")

The directory is tests not test and you need to have a python module there. So the following would be correct:
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "tests.settings")