wenchaod / fspagerview Goto Github PK

How do I centralize?

Example:

In the iOS 11 SDK, UIControlContentHorizontalAlignment gained two new cases: .leading and .trailing. FSPageControl.swift no longer builds because the switch on self.contentHorizontalAlignment in layoutSublayers doesn't cover these cases.

hi @WenchaoD i have problem with selectedForegroundView, when i custom fspagerviewcell, when call scrollToItem (or didSelectItemAt) this fspagerviewcell will have a view empty top, i cant touch most of button on fspagerviewcell.
https://yadi.sk/i/r2IdG2kI3HXeMU

Hi @WenchaoD many thanks for support, How i can set images start show letf on FSPagerView.
https://yadi.sk/i/7s9_IwII3Ht6Xo

Great library!

I hope to when only 1 data just show 1 cell

你好！手动拖FSPagerView 这个文件夹到工程，不能正常使用呢，找不到FSPagerView这个类，引用不了。
使用CocoaPods安装，找不到FSPagerControl 那个类，import不了。
PS：可否公开下实现方式的代码。 还有怎么实现的FSPagerView类像是系统类（在xcode 里显示是蓝色字体）的？ O(∩_∩)O谢谢 开源！

Why origin is set to contentOffset
Bounds of the origin of the default is (0, 0 )

I want to hide shadow in my custom cell. Thanks!

Hi there
i wanna to implement fspagerview in tableHeaderView of uitableview. after pagerView.reloadData() cellForItemAt... not called but numberOfItems fired !!

`

    let nib = UINib(nibName: "BannerViewNew", bundle: nil)
    self.newsListTableView.register(nib, forHeaderFooterViewReuseIdentifier: "BannerViewNew")
    let cell = self.newsListTableView.dequeueReusableHeaderFooterView(withIdentifier: "BannerViewNew") as! BannerViewNewCell
    cell.frame = CGRect(x: 0.0, y: 0.0, width: self.newsListTableView.frame.width, height: 250.0)
    cell.pagerView.frame = cell.frame
    cell.pagerView.delegate = self
    cell.pagerView.dataSource = self
    cell.pageControl.numberOfPages = bannerList?.count ?? 0
    cell.pagerView.reloadData()
    self.newsListTableView.tableHeaderView = cell`

Can I add two viewpager in same class? I already did this :

public func pagerView(_ pagerView: FSPagerView, cellForItemAt index: Int) -> FSPagerViewCell {
        
        if pagerView == self.viewPager {
            let cell = pagerView.dequeueReusableCell(withReuseIdentifier: "TheCell", at: index)
            viewPagerControl.numberOfPages = self.arrRes.count
            
            if index < arrRes.count  {
                var dict = arrRes[index]
                print("IMAGE FROM JSON : \(dict["image"] as? String)")
                
                // Convert Optional String to String
                if let value = dict["image"] as? String {
                    print("VALUE STRING UNWRAP : \(value)")
                    
                    let imageURLString = "http://mywebsite.com"
                    print(imageURLString)
                    
                    let realUrl = URL(string: imageURLString)
                    cell.imageView?.kf.setImage(with: realUrl)
                    cell.imageView?.contentMode = .scaleAspectFill
                    cell.imageView?.clipsToBounds = true
                    
                }
                
            }
            return cell
        }
        if pagerView == self.produkPopulerViewPager {
            let cell = pagerView.dequeueReusableCell(withReuseIdentifier: "TheProduk", at: index)
            cell.imageView?.image = UIImage(named: self.imageNames[index])
            cell.imageView?.contentMode = .scaleAspectFill
            cell.imageView?.clipsToBounds = true
            //cell.textLabel?.text = index.description+index.description
            return cell
        }
        
        return FSPagerViewCell()
        
    }

If I run the app, the only work and apear is first viewPager.

Is there a way to start the pagerView off at a certain index?
How can I do this on viewDidLoad without starting of the pagerView at index 0 ?

当只有两张图片的时候，一次从左往右，第二次滚动会从右往左。
如图所示

If I want to scroll next and previous images by buttons too
what the action will be in my next & previous buttons?

FSPagerViewCell comes with:
textLabel
imageView

I want to use a ViewCell with a UIView inside that I can set with a custom View
Something like that:
subview

How can I do that?

Can you add the supporting for customize automaticSliding animation duration please?

1. If just try to use: pod 'FSPagerView' we see the error in terminal:
   [!] Unable to find a specification for FSPagerView.
   Resolved with try to use pod with a link to git repository like this:
   pod 'FSPagerView', :git => 'https://github.com/WenchaoD/FSPagerView.git'

2. And when I add this lib, and try to FSPagerView to storyboard I have a warning:

Halo again,

If I want to give margin between the item is that posible? Or are you already give this feature in this library?

It is recommended to load web images

Hey,

I would like to use your library to implement centered cells with custom width, and infinite scrolling.
But trying to register my custom cell - that subclasses FSPagerViewCell - still produces a normal FSPagerViewCell. I cast the cell to my custom cell in cellForItemAt.

Also, for some reason i cannot scroll the PagerView?

Thanks :)

Hi. It would be great to fix the following bug:
When I set the following:
func pagerView(_ pagerView: FSPagerView, shouldHighlightItemAt index: Int) -> Bool { return false }
then func pagerView(_ pagerView: FSPagerView, didSelectItemAt index: Int) is never called.
Of course this is not the normal behaviour: I want to be able to call didSelectItemAt but have no highlight when the item is tapped.
Thanks for fixing this bug!
NB: for those having the same issue as I have, you might be solving the issue with attaching a TapGesture to the items. I have not tested it yet though.

As I understood there is no way to find FSPagerViewCell index path.

I see podspec states this framework is only compatible with iOS. Since iOS and tvOS are very similar (especially in regard with commonly used components, such as UICollectionView) would it be possible to implement this component in a tvOS app ?

I'm talking about a behaviour Apple uses as ad banners in tvOS (App store, Movies etc..)

I have a custom cell which has buttons, but I am unable to interact with buttons at all.

Many thanks for support, please show the way run objective c.

It is 1000% possible that I missed something obvious, however my project with just an absolute barebones "just get it to build and run even if it doesn't do anything" implementation (based on readme and glancing at examples) is giving me an EXC_BAD_ACCESS (error=1, address=0x0) on the register:

    @IBOutlet weak var pagerView: FSPagerView! {
        didSet {
            self.pagerView.register(FSPagerViewCell.self, forCellWithReuseIdentifier: "cell")
        }
    }

I've tried to dig around this and figure it out on my own if I was missing something. Checked to ensure I added the class, it was added as a framework, checked any weird build steps etc.

I am also seeing:

2017-04-19 01:02:43.599 [18910:8372737] Unknown class FSPagerView in Interface Builder file.

In the runtime log.

XCode 8.2
Swift3

Hi,

Is it possible that you implement the following function of the UICollectionView :

func indexPathForItemAtPoint(_ point: CGPoint) -> NSIndexPath?

It is needed when you add a custom view with a target in a button for exemple to get the indexPath of the clicked button.

Thanks.

'M_PI_2' is deprecated: Please use 'Double.pi / 2' or '.pi / 2' to get the value of correct type and avoid casting.

this issue only exists in linear mode

internal func nextIndexPath(for indexPath: IndexPath) -> IndexPath & internal func previousIndexPath(for indexPath: IndexPath) -> IndexPath

Is it a new feature?
Or a typo

Nice work! But:
[!] Unable to find a pod with name, author, summary, or description matching FSPagerView

FSPagerView doesn't support RTL (right to left languages) requires to reverse the images, page control and scrolling direction.

Hey,

I have a custom cell, to display my own view. But the views, that are used later in queue weren't rendered correctly. I use "prepareForReuse" to use less memory and rerender, if views are shown, but the views are stuck, like they are cached or something. In normal collectionView, it works perfectly, so I think, it just appeared, since I used FSPagerView.

[_pagerView reloadData] cannot invoking the method: self.dataSource!.pagerView(self, cellForItemAt: index)

cod:

- (NSInteger)numberOfItemsInpagerView:(FSPagerView *)pagerView
{
    return self.allDataArr.count;
}
 
- (FSPagerViewCell *)pagerView:(FSPagerView *)pagerView cellForItemAtIndex:(NSInteger)index
{
    FSPagerViewCell * cell = [pagerView dequeueReusableCellWithReuseIdentifier:@"cell" atIndex:index];

        cell.imageView.image = [UIImage imageNamed:@"f1"];
        cell.imageView.contentMode = UIViewContentModeScaleAspectFill;
        cell.imageView.clipsToBounds = YES;
 
    return cell;
}

ps:the allDataArr is net request result.

@WenchaoD
this library seems does not expose the function for getting FSPagerViewCell with index, for example:

func pagerView(_ pagerView: FSPagerView, didSelectItemAt index: Int) {
        pagerView.cellForItem(at: index)
}

I've added this func in my local repo, if it's not in the current development roadmap, I'm glad to create a pull request

is there any way we can use custom cell instead of "FSPagerViewCell" ?

I created custom class "slideCell" and inherited it from "FSPagerViewCell" but its not working

class SliderCell: FSPagerViewCell {
}

I know that there'e someone also post about this issue already. But mine is also happen.
I already call :

viewPagerProduct.dataSource = self
viewPagerProduct.delegate = self

and when my data ready to get from json I call this line :

self.viewPagerProduct.reloadData()

and nothing happen. I check that by counting my value, and they are not null or 0. Any clue for this?
But the weird thing this numberOfItems function is called

Hi,

I'm currently using FSPagerView inside a UITableView, just as it was a CollectionView from this article

However, I can't find a way to set the contentOffset of the pagerView as I would for a collectionView (collectionView.contentOffset.x = newValue), to ensure that when my tableView cells are reused, the offset are preserved and my pagerView is displayed with the right currentIndex.

Basically, I would like to set the pagerView current displayed index in my tableView WillDisplayCell method, but as I try using scrollToItem it crashes with an index out of range issue showing that numberOfItems is still 0, as its data was not loaded yet.

Any idea how to accomplish that? Hope I'm clear enough, thanks for your help!

我自定义了一个headerView ：UICollectionViewCell 然后在其中添加 banner: FSPagerView
但是 添加后正常显示 但是无法手动滚动 接收事件 请教会是哪里的问题呢？
部分代码如下
//
lazy var banner: FSPagerView = {
let pagerView = FSPagerView(frame: CGRect(x: 0, y: 0, width: Constant.screenWidth, height: ConstantValue.bannerH))
pagerView.register(FSPagerViewCell.self, forCellWithReuseIdentifier: "cell")
pagerView.transformer = FSPagerViewTransformer(type: .overlap)
let transform = CGAffineTransform(scaleX: 0.7, y: 0.85)
pagerView.itemSize = pagerView.frame.size.applying(transform)
pagerView.automaticSlidingInterval = 3.0
pagerView.isInfinite = true
pagerView.delegate = self
pagerView.dataSource = self

    return pagerView
}()

//顶部容器
lazy var headerView: UIView = {
    let headerView = UIView(frame: CGRect(x: 0, y: 0, width: self.view.bounds.width, height: ConstantValue.headerH))
    headerView.backgroundColor = UIColor.blue
    headerView.addSubview(self.banner)
    return headerView
}()

lazy var layout: UICollectionViewFlowLayout = {
    let layout = UICollectionViewFlowLayout()
    layout.minimumLineSpacing = ConstantValue.cellMargin
    layout.minimumInteritemSpacing = ConstantValue.cellMargin
    
    layout.scrollDirection = .vertical
    layout.sectionInset = UIEdgeInsets(top: ConstantValue.cellMargin, left: ConstantValue.cellMargin, bottom: ConstantValue.cellMargin, right: ConstantValue.cellMargin)
    layout.headerReferenceSize = CGSize(width: self.view.bounds.width, height: ConstantValue.sectionHeaderHeight)
    return layout
}()


lazy var collectionView: UICollectionView = {
    let collectionView = UICollectionView(frame: self.view.bounds, collectionViewLayout: self.layout)
    collectionView.register(HeaderViewCell.self, forCellWithReuseIdentifier: CellIdentifier.headerCell.rawValue)
    collectionView.register(UINib(nibName: String(describing: SpreadViewCell.self), bundle: nil), forCellWithReuseIdentifier: CellIdentifier.spreadCell.rawValue)
    
    collectionView.delegate = self
    collectionView.dataSource = self
    return collectionView
}()

Hi,

if I set:
pagerView.itemSize = CGSize(width: 100, height: 100)

I get this error:

2017-02-24 19:35:44.423 ccs[62442:3672487] *** Assertion failure in -[UICollectionViewData validateLayoutInRect:], /BuildRoot/Library/Caches/com.apple.xbs/Sources/UIKit_Sim/UIKit-3600.6.21/UICollectionViewData.m:433 2017-02-24 19:35:44.433 ccs[62442:3672487] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'UICollectionView received layout attributes for a cell with an index path that does not exist: <NSIndexPath: 0x600000c301e0> {length = 2, path = 1 - 0}'

if I set it to:
pagerView.itemSize = CGSize(width: 120, height: 120)
it works

Why?

Thanks

使用默认的FSPagerViewCell是周围有灰色渐变背影，请问能否去掉？

hi there
I wanna each slide has a right-to-left title, how can i do that ?

How can we create the effect there will only be be the interitem spacing before the first cell and after the last cell, rather than a full space that creates a gap?

too much memory leak when i used Instruments to analyze

I didn't see this in the Readme, if a user swipes the screen quickly, it can scroll multiple indexes. Is it possible to make it only scroll 1 index at a time, please?

Great library, congrats 👏

How can I set the speed of the swipe's animation (i.e. actual change on the cell) and limit the swipe for only one item (i.e. 1 swipe will result in 1 cell change)?

Thanks a ton! 😁

在数据是空的情况下，并且isInfinite打开的时候会崩掉

I add the view pager manually into my code without using Storyboard, and the views and everything is worked, except for one thing The Scroll. I can't scroll viewpager if I scroll from the center or bottom side, I only can scroll if I touch and scroll them from the top side. Can you fix this?

backgroundView & contentView in FSPageView
I read the source code when the two variables do not understand
Is it more written?

Hi! Thank you very much for this awesome framework! But I want to have different sizes images in my PagerView, is it possible? I have CollectionViewController and there I implemented this moment (each image in array calculated sizes and sent them to collectionView), but here I can't get the view with custom size for each image... I think that one way to get it this is make images aspectFill, but I want to get more quality images in my app...

TNX