well-id / dliswriter Goto Github PK

Each EFLRSet has a set name.

Test that different EFLRSet instances of the same type (e.g. ChannelSet) can be correctly added to the file if they have differing set names. Check that the child EFLRItem (e.g. ChannelItem) instances are added, referenced, and retrieved correctly.

Whenever a Path object is added to the file, DeepView refuses to open it.
Sometimes issues appear also in dlisio.

Note that in RP66, Path is similar to frame and should probably be treated as such.

Use line profiling to speed up code execution.
Consider different sizes and shapes (number of rows vs number of columns) of the datasets.

When writing a file, data are loaded in chunks and the output bytes are saved in chunks.

The sizes of input and output chunks cna be specified by the user.
Size of an input chunk is currently expressed in the number of rows from a dataset.
Size of an output chunk is expressed in the number of bytes.

Both should be optimized for different shapes of datasets - combinations of different lengths (numbers of rows) and widths (number of columns, number of images, number of columns in images).

When writing the file, data are loaded in chunks,

The size of those chunks is currently specified (by the user) as the number of rows of data table loaded at a time.

Consider expressing this in bytes instead.

Test that representation_code of different Attributes is correctly determined from the value.
In particular, check the Attributes for which multivalued=True.

Attribute time of PathItem can be numerical or of datetime type. For now, only the numerical option is accepted.
Add support for datetime values.

Each EFLRItem has an attribute copy_number. It is meant to distinguish between two EFLR items of the same type and name.

The copy_number is computed automatically at the level of an EFLRItem by checking how many EFLRItem instances of the given name are already defined in the parent EFLRSet and subtracting 1 (so for the first ELFRItem of the given type and name, copy_number is 0).

However, this is only checked at the level of the parent EFLRSet of the given EFLRItem. In most cases this is sufficient, because normally a single EFLRSet of a given type is defined in a file, but it is possible to define more (see this issue). In case multiple EFLRSets are added to the same file, it is likely that multiple EFLRItem instances will share the same type, name, and copy_number, making them indistinguishable in DLIS references. As a result, references might point to the wrong items (resulting i.e. in a FrameItem displaying the wrong channel data).

Several attributes of PathItem (borehole_depth, vertical_depth, etc.; check RP66 docs) can be either (arrays of) numbers or ChannelItem instances. Now only the numerical version is supported.

Add support for ChannelItem instances being used as values of these attributes.

Marking as 'enhancement' because it's not critical and as 'bug' because this should be accepted according to the standard.