weitzman / difficode Goto Github PK

• Design using a launch page service
• Point diffi.org at it
• Explain that the way to contribute recipes is via Pull Request

I assumed that saving the whole page would cause too many diffs due to insignificant changes in the HTML. Perhaps this should be a setting in the recipe so that static pages get saved in full. Full pages preview better and may be better from a legal/academic perspective. The full pages would have an extensions like foo.privacy.full.html

(header only -- probably will be fixed if we can markdown-ify only selected HTML)

privacy.json has the right URL, but for some reason the imported HTML looks like a 403 page

And is there any way to un-minify the HTML files so that the entire policy isn't written on one line?

We are selecting the wrong part of the page at https://github.com/weitzman/diffi/blob/master/apple/privacy.html. Review the DOM selector in this recipe.

http://fuckyeahmarkdown.com/

Looks like the policy text for both lyft pages isn't actually rendered in the source code. Looking at the source, it seems like the actual text might be imported by a script.

But here's the relevant code for the policy text if you Inspect Element:

<div class="container terms-body ng-scope"> 
<section class="row m-x-s m-t-xl m-b-l p-t-l"> 
<article ng-bind-html="termsHtml" class="ng-binding">
<header class="masthead"></header>
<section>
    <article>
        <header>
            <h1> Lyft Terms of Service</h1>

I'm not sure how to make lyft's weird setup work with our diffi recipes. Any ideas? @weitzman

(header only -- probably will be fixed if we can markdown-ify only selected HTML)

(I'm tagging this as a bug for now since I think it probably has to do with heroku rather than recipes)

redirects all pages to facebook.com/unsupportedbrowser