weiiswurstdev / placestom Goto Github PK

On the latest release of the server, the server fails to start, I pinpointed the issue to the Teleport Command, line 13 looking for an integer of a system property, this is not specified in the README for running the server, here is the error:

Exception in thread "main" java.lang.ExceptionInInitializerError
        at dev.weiiswurst.placestom.PlaceServer.registerCommands(PlaceServer.java:106)
        at dev.weiiswurst.placestom.PlaceServer.main(PlaceServer.java:91)
Caused by: java.lang.NullPointerException: Cannot invoke "java.lang.Integer.intValue()" because the return value of "java.lang.Integer.getInteger(String)" is null
        at dev.weiiswurst.placestom.commands.TeleportCommand.<clinit>(TeleportCommand.java:13)
        ... 2 more

and the fix has multiple solutions, 1, have a default value, specify in the readme a system property is required or a few other options.

Here is an example, adding this to the java startup parameters:
-Dplacestom.worldborder-size=4

I think I found an actual issue this time (hopefully), when placing a block in any of the chunks, the chunk becomes dark so I assume there are no light level chunk updates or they are not occurring correctly, I am running vanilla 1.18.2 on the client and when relogging, the light resets, here is a screenshot of what I mean:
https://cdn.jordanplayz158.xyz/uploads/be5793f44f02c69c2a046309912bb606c0a1b558.png

I noticed the error in initialization of the PlaceBlocks object and checked to see and noticed the log error on line 61 ("Unable to load allowed blocks. Will default to list of concrete blocks, creating a map will not work") and as I didn't specify an allowed blocks list, I tried to and it resulted in the same error (I tried -Dplacestom.blocks.allowed-blocks=grass_block,dirt_block), also it spams this

Exception in thread "ForkJoinPool.commonPool-worker-1" java.lang.NoClassDefFoundError: Could not initialize class dev.weiiswurst.placestom.world.PlaceBlocks
        at dev.weiiswurst.placestom.world.PlaceLoader.generateChunkData(PlaceLoader.java:32)
        at net.minestom.server.instance.batch.ChunkGenerationBatch.lambda$generate$0(ChunkGenerationBatch.java:34)
        at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1395)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
        at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

in console which makes the log error unintuitive if it even gets to this point (not sure if it's erroring before or after that log or if the error isn't gracefully handled) also this is not documented or mentioned anywhere in the readme, also there should be a default fallback that allows terrain to generate normally without spam erroring out on player join (Might make a pr to fix the 2 issues