webwareforpython / w4py Goto Github PK

It is impossible to use non-ASCII character encoding on python server pages because the PSP compiler does not add the required encoding declaration as required by http://python.org/dev/peps/pep-0263/ at the beginning of the compiled python files.

This restriction renders PSP useless for most foreign users. I suggest adding an encoding option string to Application.config which in turn gets written into the compiled PSP page files.

There is a RuntimeError at line 286 in SessionDynamicStore memoryKeysInAccessTimeOrder

self._memoryStore is iterated over directly, instead of pulling the list of keys first.

https://github.com/Cito/w4py/blob/master/WebKit/SessionDynamicStore.py#L286

286c286
<         for key in self._memoryStore:

---
>         for key in self._memoryStore.keys():

Sprinkled throughout the code are comments tagged with @@ which are hopefully accompanied by a date and someone's initials. These comments represent things to be done. The double at-sign (@@) convention was chosen because it doesn't appear to be used for anything else.

There are also "FUTURE" items mentioned in class doc strings and comments.

Remove any such comments, since w4py2 will not be developed further, or create w4py3 issues on GitHub if changes are still desirable.