Comments (4)
Wouldn't peer-wire-protocol
work in the browser using browserify?
from webtorrent.
I gave it a shot but ran into problems because you used the node Buffer
which doesn't exist in the browser. So, browserify adds it's own shoddy buffer implementation which is slow and has weird bugs. The right way to do it, as I understand it, is to use bops which works in both environments with the same API -- it uses Buffer
in node and Uint8Array
in the browser.
But you're right -- I should investigate more before doing a fork of peer-wire-protocol... Would you accept a pull request that uses bops
and might decrease performance a bit (since with bops
you sometimes have to do a copy where with Buffer
you don't need to)?
from webtorrent.
This task is finished. See bittorrent-protocol (fork of peer-wire-protocol) which works in the browser. It initially used bops
but I switched it to just use normal Buffers with native-buffer-browserify
which will be merged in browserify hopefully soon. I'm not sure what (if anything) is different in the fork, but I expect these changes can be merged upstream.
from webtorrent.
Sorry for not getting back to you. Looks great.
Just skimmed your source and overall it looks very similar. I'd be happy to include these changes in peer-wire-protocol and add you as a maintainer if you want (to avoid having two very similar modules)?
from webtorrent.
Related Issues (20)
- Extend to allow standard websockets HOT 2
- WebTorrent.remove method removes correct torrent and, incorrectly, the last torrent HOT 1
- 🐛 Issue with Next.js: Can't resolve 'dgram' HOT 4
- Hi, I have built a collaborative video editor with webtorrent support HOT 1
- Introduction example is broken on https://webtorrent.io/intro HOT 4
- Do not use the old `import ... assert` syntax. HOT 1
- failed to build in Electron with utp-native error HOT 5
- autoStart option for client.add HOT 4
- client.seed() doesn't start unless client is restarted HOT 3
- wrong Return Value type of client.get() in @types/webtorrent packages HOT 1
- Update Flatpak version HOT 1
- Version 2.2.1 requires webrtc-polyfill due to loose dependency on torrent-discovery HOT 4
- Filename is overridden by the torrent name when seeding a single file HOT 1
- Already downloaded files are not showing inside torrent.files array HOT 2
- Cannot find module "node_datachannel.node" HOT 1
- Syntax error on webtorrent-min.js for multiple version HOT 5
- TypeError: Cannot read properties of null (reading 'isIP') HOT 6
- de-duplicate IP packages
- Publish on Flathub HOT 1
- Metadata is forgotten on page reload HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webtorrent.