Code Monkey home page Code Monkey logo

Comments (4)

mafintosh avatar mafintosh commented on July 22, 2024

Wouldn't peer-wire-protocol work in the browser using browserify?

from webtorrent.

feross avatar feross commented on July 22, 2024

I gave it a shot but ran into problems because you used the node Buffer which doesn't exist in the browser. So, browserify adds it's own shoddy buffer implementation which is slow and has weird bugs. The right way to do it, as I understand it, is to use bops which works in both environments with the same API -- it uses Buffer in node and Uint8Array in the browser.

But you're right -- I should investigate more before doing a fork of peer-wire-protocol... Would you accept a pull request that uses bops and might decrease performance a bit (since with bops you sometimes have to do a copy where with Buffer you don't need to)?

from webtorrent.

feross avatar feross commented on July 22, 2024

This task is finished. See bittorrent-protocol (fork of peer-wire-protocol) which works in the browser. It initially used bops but I switched it to just use normal Buffers with native-buffer-browserify which will be merged in browserify hopefully soon. I'm not sure what (if anything) is different in the fork, but I expect these changes can be merged upstream.

from webtorrent.

mafintosh avatar mafintosh commented on July 22, 2024

Sorry for not getting back to you. Looks great.
Just skimmed your source and overall it looks very similar. I'd be happy to include these changes in peer-wire-protocol and add you as a maintainer if you want (to avoid having two very similar modules)?

from webtorrent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.