Code Monkey home page Code Monkey logo

Comments (7)

webpro avatar webpro commented on September 23, 2024 1

Sure, I'll cherry-pick those commits into canary & publish today!

from knip.

webpro avatar webpro commented on September 23, 2024 1

Published: https://github.com/webpro/knip/releases/tag/4.0.0-canary.8

from knip.

webpro avatar webpro commented on September 23, 2024

Thanks for posting this. Is this about v4? Otherwise I prefer not to spend my time on it. Please try v4 canary and see what diff that makes.

from knip.

drodil avatar drodil commented on September 23, 2024

Ah, it's v3. I can check the v4 as well!

from knip.

drodil avatar drodil commented on September 23, 2024

V4 report here: processed2.txt (markdown reporter was not usable in v4 yet)

V4 time: 7.66s user 1.54s system 99% cpu 9.214 total
V3 time: 7.86s user 1.69s system 123% cpu 7.724 total

Not so much difference in execution time between the versions though there are some improvements for V4 visible. Randomly the time is longer for both but that's normal, it's around 7-8 seconds for this one package usually with both versions.

Seems like most of the time both v3 and v4 is going to read the files in SourceFileManager::getSourceFile so not sure if there's much to do about it.

from knip.

webpro avatar webpro commented on September 23, 2024

Yes, no surprises here. Performance is generally much better when linting a monorepo as a whole (as opposed to per workspace separately). Also see https://knip.dev/blog/slim-down-to-speed-up for some additional background.

from knip.

drodil avatar drodil commented on September 23, 2024

Alright thanks, any chance to get the markdown reporter also included in the canary? I think backstage could start using the canary version then because at the moment only the dependency checks are enabled from knip.

from knip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.