Code Monkey home page Code Monkey logo

Comments (4)

webpro avatar webpro commented on September 23, 2024

Both are fine, the latter is recommended.

The docs don't contradict anything here?

from knip.

swingthrough avatar swingthrough commented on September 23, 2024

When using ignore, based on the statement:

This is not a good idea, since ignore patterns have only one goal: to exclude issues in matching files from the report. Files matching ignore patterns are not excluded from the analysis, only their issues are not reported.

If I just ran knip command:

exclude issues in matching files from the report

I would expect it to report e.g. an unused export inside of mockServiceWorker.js.

Files matching ignore patterns are not excluded from the analysis, only their issues are not reported.

In the list of unused files, I would expect mockServiceWorker.js to still be shown.

from knip.

swingthrough avatar swingthrough commented on September 23, 2024

Okay I think I get it now, it also states:

This also hurts performance, since the files are first analyzed, and eventually filtered out.

I interpreted the part "only their issues are not reported" as issues inside the file, but I guess it means the whole file being unused is also an issue of the file, and therefore filtered out (but only after the analysis ran on the file).

from knip.

webpro avatar webpro commented on September 23, 2024

Indeed! Any issue with files that match the ignore pattern is not reported.

from knip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.