Code Monkey home page Code Monkey logo

Comments (6)

webpro avatar webpro commented on May 25, 2024

Absolutely. This has actually been in some old version, but it will be back as a new feature after v1 lands.

from knip.

webpro avatar webpro commented on May 25, 2024

The feature to add paths has been added in v1.6.0. Also see the docs at https://github.com/webpro/knip#paths.

from knip.

mcmxcdev avatar mcmxcdev commented on May 25, 2024

I am not entirely sure but I think knip only checks for tsconfig.json but not other variations of that filename right?

With https://nx.dev/ which we use, it's common to have a tsconfig.base.json (notice the name) at the root of the project.

When running knip without any config, I see our custom lib names as "Unlisted or unresolved dependencies".
When basically copying and pasting the paths from compilerOptions.paths to knip.json paths, these unresolved deps are gone. So I think it would make sense to support tsconfig.base.json out of the box.

from knip.

mcmxcdev avatar mcmxcdev commented on May 25, 2024

Additionally, we have imports like ~/components/plans-details/TierCircle which show up as unresolved.

The tsconfig.paths config for that is:

"~/*": ["./*"]

Just putting my 2 cents here since its related to import path aliases improvements 😄

from knip.

webpro avatar webpro commented on May 25, 2024

I am not entirely sure but I think knip only checks for tsconfig.json but not other variations of that filename right?

With https://nx.dev/ which we use, it's common to have a tsconfig.base.json (notice the name) at the root of the project.

When running knip without any config, I see our custom lib names as "Unlisted or unresolved dependencies". When basically copying and pasting the paths from compilerOptions.paths to knip.json paths, these unresolved deps are gone. So I think it would make sense to support tsconfig.base.json out of the box.

The default is indeed tsconfig.json (in root and/or in any workspace package). This can be overridden using -t or --tsConfig. When there is an extends in the TS config, that should work fine, too. You should not need to manually copy over the paths when using TS config.

from knip.

webpro avatar webpro commented on May 25, 2024

Going to close this one as I think the original issue is resolved.

from knip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.