Webpack plugin breaks if `--env` vars are used about knip HOT 4 CLOSED

However, requiring changes to source code will not help adoption.

One of the goals of Knip is absolutely to be as unobtrusive as possible (also see https://knip.dev/explanations/why-use-knip). But to handle each and every edge case in so many plugins (without including the ocean of tools themselves) is near impossible.

Another goal is to minimize configuration necessary on the user's end.

That said, once the plugins API is a bit more stable and more use cases better identified (this issue helps a lot with that!), there might be room to further improve Knip in this area.

from knip.

Detect or provide a way to pass env vars to webpack dependency resolution.

Not sure if/when Knip will feature custom configs for plugins. For now, I'd recommend to use a fallback value for things like env.variant ?? 'fallback/default-variant'. Just to be clear: Knip certainly doesn't want to tell you how to do things, but for this seems to only way to circumvent the breakage? Another solution is to disable the plugin (webpack: false).

As a side note, it would also be nice to configure CONFIG_FILE_PATTERNS as the webpack config files may be named differently if --config is passed.

You can do this today using webpack: 'webpack.config.js' or webpack: { config: 'webpack.config.js' } } in your Knip config. I realize now this should definitely be documented better.

from knip.

Detect or provide a way to pass env vars to webpack dependency resolution.

Not sure if/when Knip will feature custom configs for plugins. For now, I'd recommend to use a fallback value for things like env.variant ?? 'fallback/default-variant'. Just to be clear: Knip certainly doesn't want to tell you how to do things, but for this seems to only way to circumvent the breakage? Another solution is to disable the plugin (webpack: false).

Thanks, indeed fallbacks is what I went for with my poc of introducing knip to a larger database. However, requiring changes to source code will not help adoption.

As a side note, it would also be nice to configure CONFIG_FILE_PATTERNS as the webpack config files may be named differently if --config is passed.

You can do this today using webpack: 'webpack.config.js' or webpack: { config: 'webpack.config.js' } } in your Knip config. I realize now this should definitely be documented better.

Thanks! Does that option support wildcards? We have split the config file to common, dev and prod.

from knip.

Thanks! Does that option support wildcards? We have split the config file to common, dev and prod.

Yes, globs.

from knip.