Code Monkey home page Code Monkey logo

Comments (5)

arnoud-dv avatar arnoud-dv commented on June 20, 2024
Scherm­afbeelding 2023-11-30 om 10 36 10

I know the message is not coming from Knip itself, it comes from mapWorkspaces which is called from Knip. When it finds package.json files with the same name property it throws an error.

Hope this clarifies it a bit: in the sourcecode of an Angular package is a package.json. When building a package, ng-packgr generates a package.json file in the build directory. The build directory will then become the published package. I just want to exclude the built package.json from analysis by Knip. mapWorkspaces allows passing a glob pattern through its ignore parameter which is perfect as it will not collect the package and won't throw an error.

To add: Separately from the issue I have I also think it's more correct that if a directory is in ignoreWorkspaces that it won't be accessed at all.

from knip.

arnoud-dv avatar arnoud-dv commented on June 20, 2024

Here is the full error message and stack trace:

Reading workspace configuration(s)...
/Users/arnoud/code/opensource/query/node_modules/.pnpm/@[email protected]/node_modules/@npmcli/map-workspaces/lib/index.js:64
  return Object.assign(new Type(message), { code })
                       ^

Error: must not have multiple workspaces with the same name
package '@tanstack/angular-query-devtools-experimental' has conflicts in the following paths:
    /Users/arnoud/code/opensource/query/packages/angular-query-devtools-experimental
    /Users/arnoud/code/opensource/query/packages/angular-query-devtools-experimental/build
package '@tanstack/angular-query-experimental' has conflicts in the following paths:
    /Users/arnoud/code/opensource/query/packages/angular-query-experimental
    /Users/arnoud/code/opensource/query/packages/angular-query-experimental/build
    at getError (/Users/arnoud/code/opensource/query/node_modules/.pnpm/@[email protected]/node_modules/@npmcli/map-workspaces/lib/index.js:64:24)
    at mapWorkspaces (/Users/arnoud/code/opensource/query/node_modules/.pnpm/@[email protected]/node_modules/@npmcli/map-workspaces/lib/index.js:146:11)
    at async ConfigurationChief.getManifestWorkspaces (file:///Users/arnoud/code/opensource/query/node_modules/.pnpm/[email protected][email protected]/node_modules/knip/dist/ConfigurationChief.js:191:28)
    at async ConfigurationChief.setWorkspaces (file:///Users/arnoud/code/opensource/query/node_modules/.pnpm/[email protected][email protected]/node_modules/knip/dist/ConfigurationChief.js:165:35)
    at async ConfigurationChief.init (file:///Users/arnoud/code/opensource/query/node_modules/.pnpm/[email protected][email protected]/node_modules/knip/dist/ConfigurationChief.js:105:9)
    at async main (file:///Users/arnoud/code/opensource/query/node_modules/.pnpm/[email protected][email protected]/node_modules/knip/dist/index.js:27:5)
    at async run (file:///Users/arnoud/code/opensource/query/node_modules/.pnpm/[email protected][email protected]/node_modules/knip/dist/cli.js:23:73)
    at async file:///Users/arnoud/code/opensource/query/node_modules/.pnpm/[email protected][email protected]/node_modules/knip/dist/cli.js:74:1 {
  code: 'EDUPLICATEWORKSPACE'
}

from knip.

webpro avatar webpro commented on June 20, 2024

Right. I guess was confused, because just the other day I implemented the feature, but tested against workspaces not read through mapWorkspaces (but additional ones configured in knip.json), so I didn't recognize the error message without the stack trace.

from knip.

webpro avatar webpro commented on June 20, 2024

Since workspaces can also be ignored in the package manager config itself, and #374 itself is also closed, closing this one.

from knip.

TkDodo avatar TkDodo commented on June 20, 2024

@webpro I get the error even if I explicitly ignore the build package:

ignoreWorkspaces: [
    'examples/**',
    'packages/angular-query-devtools-experimental/build/**',
  ],

from knip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.