The amp-magento from webgriffe

amp-magento's People

Contributors

Stargazers

Watchers

amp-magento's Issues

Change implementation of method \Webgriffe\AmpMagento\ApiClient::getProductAttributeByCode

Why is it using the endpoint GET /V1/products/attributes filtering by attribute code? Wouldn't it be better if it used the endpoint GET /V1/products/attributes/{attributeCode}?

ObjectMerger always add new customer group prices instead of replacing existing ones

The array of customer group prices is made of customer_group_id, qty, and price . The two fields customer_group_id and qty should act as a key: if you merge an item with the same values of customer_group_id and qty, it should be replaced, but now it is always added.
Fo example if you have product with:

            [
                [
                    'customer_group_id' => 4,
                    'qty' => 1,
                    'value' => 10
                ]
            ]

and you merge

            [
                [
                    'customer_group_id' => 4,
                    'qty' => 1,
                    'value' => 15
                ]
            ]

the expected result is

            [
                [
                    'customer_group_id' => 4,
                    'qty' => 1,
                    'value' => 15
                ]
            ]

while the actual result is

            [
                [
                    'customer_group_id' => 4,
                    'qty' => 1,
                    'price' => 10
                ],
                [
                    'customer_group_id' => 4,
                    'qty' => 1,
                    'value' => 15
                ],
            ]