web3-storage / pail Goto Github PK

I think the majority of operations are async because of the async Block.encode, however it only really is like that because the hash interface used to be async only. It's now optinally async and we're just using sha256 which can be sync in Nodejs. We could switch to an Await<T> interface that allows async/sync operation depending on the environment. This might speed up mutations in Nodejs.

We currently iterate over the entire shard when searching for a key. We could so a binary search instead to speed it up.

Looks like the blockstore-core interface may have changed? Get's returned values are currently just Uint8Array instead of { cid, block } objects.

This results in broken usage:

https://github.com/alanshaw/pail/blob/777cbbafada0ca13494934331a6df999a273346c/README.md?plain=1#L22-L28

due to

https://github.com/alanshaw/pail/blob/777cbbafada0ca13494934331a6df999a273346c/src/shard.js#L67-L76

Here block is a Uint8Array and .bytes is undefined

The current API is purposely low level and stateless.

readme suggests we use blockstore-core. but pail expects get(cid) => {cid, bytes}, while blockstore-core.get returns a unit8array see: https://ipfs.github.io/js-stores/classes/blockstore_core.MemoryBlockstore.html#get

Currently missing.