wdjwxh / git-php Goto Github PK

Code highlighting sucks. I've tried various snippets from around the web
and none work right. php's highlight_string() works well for php code, but
not diffs or any other code. Now I don't highlight anything but php code
(and diffs that look like crap). I REALLY want code highlighting and line
numbering like gitweb.cgi has.

What steps will reproduce the problem?
1. Follow a commitdiff link in a project

In the project summary (html_shortlog) page the commit comments are
truncated for visual reasons. If the user follows a commitdiff link with a
truncated comment it should be displayed in full on the commitdiff page.

I'm thinking remove the "Summary" all together in a commitdiff and give
more information on the particular commit

What steps will reproduce the problem?
1. git clone http://zackb.org/git/git-php.git
2. server does now response

Use git-tar-tree to build the tar.gz snapshots

Website is down and unable to clone? is this project still going or is it 
defunct?

slsmpb05:Desktop ws0sca$ git clone http://zackb.org/git/git-php.git
Initialized empty Git repository in /Users/ws0sca/Desktop/git-php/.git/
error: Couldn't resolve host 'zackb.org' while accessing 
http://zackb.org/git/git-php.git/info/refs

fatal: HTTP request failed

dgd

"Plain" file saving needs the proper file name. header("...")

The name field when a commit is merged is messed up. must be that ghetto
parsing of git-commit

there are several ways invalid repo paths can get into $repos. Repos should
be verified to exist and then verified to be a valid git repo.

I tried to install git-php, but there is no installation tutorial. 
However, i updated my repos-array with my repos-path, but it doesn't show
me the contents of my repos. A installation how to would be helpfull.
Are there any other steps to install git-php necessary?

Code highlighting sucks. I've tried various snippets from around the web
and none work right. php's highlight_string() works well for php code, but
not diffs or any other code. Now I don't highlight anything but php code
(and diffs that look like crap). I REALLY want code highlighting and line
numbering like gitweb.cgi has.

need to add the full path to the git programs. Currently the git-php
assumes they are in $PATH.

I created a quick & dirty clone url support. See attachment.

I just updated a little this script to make it work on php5 immediately ...
I send you the patch if you want :

In commitdiff or diff output scrap the hightlight_code() call and manually
set - lines to red color and + lines to green. Easier to read.

need to add the full path to the git programs. Currently the git-php
assumes they are in $PATH.

Hi I add this little feature to git-php.
I know that probably this project is died but I like it powerful and easy
configuration.

Allow the end user to disable tar.zg/zip snapshot download.

diff --git a/config.php b/config.php
index 1bff39a..b167bfb 100644
--- a/config.php
+++ b/config.php
@@ -18,15 +18,18 @@

        /* True if committing is active */
        $git_commiting_active = true;
+
+       /* True if you like to allow tar.gz/zip download */
+       $git_download_active = true;

        /* E-mail address to notify about the bundles */
        $emailaddress = "[email protected]";

diff --git a/git.php b/git.php
index ea83754..b69ab84 100644
--- a/git.php
+++ b/git.php
@@ -187,7 +187,7 @@ if (isset($_GET['dl']))
     write_plain();
   else if ( in_array( $_GET['dl'], $icondesc, true ) )
     write_img_png($_GET['dl']);
-  else if ($_GET['dl'] == 'dlfile' )
+  else if ($_GET['dl'] == 'dlfile' && $git_download_active)
     write_dlfile();
   else if ($_GET['dl'] == 'rss2')
     write_rss2();
@@ -529,7 +529,8 @@ function html_home()
   echo "<th>Description</th>";
   echo "<th>Owner</th>";
   echo "<th>Last Changed</th>";
-  echo "<th>Download</th>";
+  if ($git_download_active)
+      echo "<th>Download</th>";
   echo "<th>Hits</th>";
   echo "</tr>\n";
   foreach ($repos as $repo)   {
@@ -540,7 +541,10 @@ function html_home()
     $proj = get_project_link($repo);
     $dlt = get_project_link($repo, "targz");
     $dlz = get_project_link($repo, "zip");
-    echo
"<tr><td>$proj</td><td>$desc</td><td>$owner</td><td>$last</td><td>$dlt
+    echo "<tr><td>$proj</td><td>$desc</td><td>$owner</td><td>$last</td>";
+    if ($git_download_active) 
+        echo "<td>$dlt | $dlz</td>";
+    echo "<td> ( $today / $total ) </td></tr>\n";
   }
   echo "</table>";
 }
@@ -583,9 +587,9 @@ function get_project_link($repo, $type = false,
$tag="HEAD")
   $path = basename($repo);
   if (!$type)
     return "<a href=\"".sanitized_url()."p=$path\">$path</a>";
-  else if ($type == "targz")
+  else if ($type == "targz" && $git_download_active)
     return html_ahref( array( 'p'=>$path, 'dl'=>'targz', 'h'=>$tag )
).".tar.gz
-  else if ($type == "zip")
+  else if ($type == "zip" && $git_download_active)
     return html_ahref( array( 'p'=>$path, 'dl'=>'zip', 'h'=>$tag )
).".zip</a>"
 }

The "Demo" link on the project homepage is broken. It leads to a spam page.

The last line of the "plain" file output duplicates that last line.