wayofthepie / sip Goto Github PK

Currently parsers, especially the common ones like doublep and intp, are pretty inconsistent, so is the module structure.

Following is a partial list of inconsistencies which need to be addressed, there are likely many others:

• doublep will consume whitespace but intp will not.
• Module intent should be made more explicit
  • Move common functions into Common
  • Be clear with the intent of each module - for example Linux.Parser.Internal.Proc covers parsers for root proc files (/proc/) and per process files (/proc/[pid]/**).
• The ProcessStat data structure is duplicated, it exists in both the modules Linux.Parser.Internal.Proc and Linux.Parser.Proc . the latter should probably be removed.
• It's not clear what the Linux.Graph.SystemInfo module is for anymore, maybe this should be re-thought and put into a separate package?
• Record and function naming conventions are terrible! Perhaps investing time into the records library would be worthwhile.

Currently there is a mix of parsec and attoparsec, it would make sense to use attoparsec only.

Currently there are 0 tests! Refactoring can easily cause logic issues in the parsers.

There should at the very least be quickcheck tests against the top level parsers.