waymondo / apropospriate-theme Goto Github PK

Hi,

Thank you for the great theme. One thing I noticed is that when I edit an source code example with C-c ', the background color for the block being edited becomes yellow, which is too bright for the dark theme:

Would it be possible to change this to a more subdued color?

Its all beautiful on terminal but that green line(#C5E1A5):

imgur

PS: Spacemacs on Suckless St terminal

Thanks

Hey, liking the theme.

Wanted to request being able to skip mode line font height being set by the theme.

Thanks!

Marking the region in the current line while hl-line-mode is active, gives the mark a color which is very similar to the current line, making it very difficult to recognize.
The situation is better when it comes to the light version of the theme. But gets a little problematic on the dark version.
Support for hl-line-mode would be helpful

In my configuration "dired-directory" is not being set to the right color.

Without ido, "dired-directory" can't inherit from ido-subdir. To fix this, I use this configuration:

(defface ido-subdir  '((((min-colors 88) (class color))
                        :foreground "red1")
                       (((class color))
                        :foreground "red")
                       (t :underline t))
  "Face used by Ido for highlighting subdirs in the alternatives."
  :group 'ido)

(use-package apropospriate-theme
  :demand
  :config
  (load-theme 'apropospriate-dark))

As a fix for this, I suggest swapping ido-subdir and dired-directory so ido-subdir inherits from sired-directory.

Started using this cool theme and want to raise request for neotree mode:

from spacemacs theme we have the following for neotree

`(neo-dir-link-face ((,class (:foreground ,keyword :inherit bold))))
  `(neo-expand-btn-face ((,class (:foreground ,base))))
  `(neo-file-link-face ((,class (:foreground ,base))))
  `(neo-root-dir-face ((,class (:foreground ,func :inherit bold))))

can we get the similar from this theme as well pls? thanks

The current colours in ediff make it nearly impossible to read the right hand side of the diff. I've attached a screenshot which shows off some of the problems. Thanks!

request to add the following faces per this theme. thanks.

from spacemacs theme:
```
(org-ellipsis ((,class (:foreground ,keyword)))) (org-level-1 ((,class (:inherit bold :foreground ,head1 :height ,(if spacemacs-theme-org-height 1.3 1.0) :background ,(when spacemacs-theme-org-highlight head1-bg)))))
`(org-level-2 ((,class (:inherit bold :foreground ,head2 :height ,(if spacemacs-theme-org-height 1.2 1.0) :background ,(when spacemacs-theme-org-highlight head2-bg)))))
`(org-level-3 ((,class (:bold nil :foreground ,head3 :height ,(if spacemacs-theme-org-height 1.1 1.0) :background ,(when spacemacs-theme-org-highlight head3-bg)))))
`(org-level-4 ((,class (:bold nil :foreground ,head4 :background ,(when spacemacs-theme-org-highlight head4-bg)))))
`(org-level-5 ((,class (:bold nil :foreground ,head1))))
`(org-level-6 ((,class (:bold nil :foreground ,head2))))
`(org-level-7 ((,class (:bold nil :foreground ,head3))))
`(org-level-8 ((,class (:bold nil :foreground ,head4))))

;;;;; mu4e
(mu4e-cited-1-face ((,class (:foreground ,base)))) (mu4e-cited-7-face ((,class (:foreground ,base))))
(mu4e-header-marks-face ((,class (:foreground ,comp)))) (mu4e-header-key-face ((,class (:foreground ,head2 :inherit bold))))
(mu4e-view-url-number-face ((,class (:foreground ,comp)))) (mu4e-unread-face ((,class (:foreground ,yellow :inherit bold))))

;;;;; cider
(cider-enlightened ((,class (:background nil :box (:color ,yellow :line-width -1 :style nil) :foreground ,yellow)))) (cider-enlightened-local ((,class (:foreground ,yellow))))
(cider-instrumented-face ((,class (:background nil :box (:color ,red :line-width -1 :style nil) :foreground ,red)))) (cider-result-overlay-face ((,class (:background nil :box (:color ,blue :line-width -1 :style nil) :foreground ,blue))))
(cider-test-error-face ((,class (:background ,war :foreground ,bg1)))) (cider-test-failure-face ((,class (:background ,err :foreground ,bg1))))
(cider-test-success-face ((,class (:background ,suc :foreground ,bg1)))) (cider-traced-face ((,class :box (:color ,cyan :line-width -1 :style nil))))

Hey, thanks for this great theme...

Ive tried to find out where these colors are without success, can you guys help:

Bottom: (Really exit emacs y/n)

Hi @waymondo,

Thanks for creating a terrific theme. I really like the color scheme for web-mode / html-mode . Really nice color contrasts.

On installing apropospriate-theme with use-package and also with require statements I get "Eager macro-expansion failure: (error "Lisp nesting exceeds `max-lisp-eval-depth'").

On following advice in this SO article and putting in (setq max-lisp-eval-depth 10000) prior to where I put the use-package apropospriate statement I get "Eager macro-expansion failure: (error "Variable binding depth exceeds max-specpdl-size").

The error/warning messages don't seem to impact functionality of the theme, other than slowing down the startup of emacs. I'd like to get rid of that slowdown in my personal emacs.d setup. Do you have any advice?

Hello, thanks for a great theme! I have a small issue with a search that it covers a matching line. You can see it on screenshot on line with a point. How can I fix that?

In the following screenshot, -g is selected white -c, -d and -S are not. But it is really hard to distinguish. May I suggest orange for the selected switches.

edit: the faces are:
magit-popup-argument (selected switch)
magit-popup-disabled-argument (not selected switch)

Avy let you navigate faster. In apropospriate-dark (I haven't tested in light) the background and the color of the shortcut chars added by avy are exactly the same as the text, so it's very hard to use

I can reproduce this behavior when running emacs -q and loading the packages directly.

Thanks!

Hi,

I've been using apropospriate regularly now and it seems stable. Can you make a versioned release so that it can be included in the MELPA stable set?

It would be nice to fix support Git Messenger

https://github.com/syohex/emacs-git-messenger

For now it looks sometimes wrong — http://take.ms/gqZPeH

Evil users are used to have a vertical bar as a cursor shape in insert state. the hbar is reserved for replace state, usually.

I had to write this on my init.el:

(load-theme 'apropospriate-light t)

  ;; ;; fix cursor shape
  (setq evil-insert-state-cursor 'bar)

ps: I'm the reddit thread starter by the way: /u/Eldrik o/

What's happening is hard to say, but it looks like apropospriate-theme is screwing up my mode line:

Notice the overwriting of the "a" and the "1".

Gah, hit enter too early, sorry.

How do you feel about having a background color for org-blocks? (like #+BEGIN_SRC and #+END_SRC)

I'm happy to submit a PR if you are okay with them having either a lighter or darker background.

as of now an org-link is undistinguishable from a normal word. sample attached (using light theme)

awesome work by the way.

I have the following setup. I've forced loading apropospriate-theme, like you can see in the example, though it's not needed with the solarized-theme.

     (use-package solarized-theme
       :ensure t
       :no-require t)

     (use-package apropospriate-theme
       :ensure t
       :init
       (progn
         (load-theme 'apropospriate-light t t)
         (load-theme 'apropospriate-dark t t)))

     (use-package theme-changer
       :ensure t
       :config (change-theme 'apropospriate-light  'apropospriate-dark))

Only thing I've noticed was this message in the messages buffer, which shows up weather theme-changer is actually loading this theme or not.

Could not load apropospriate-theme

The theme loads and works just fine when the last block is evaluated manually.

i.e. This setup, or indeed simply invoking (load-theme ...) work without any problem. But the said message still appears, regardless of use in theme-changer.

     (use-package theme-changer
       :ensure t
       :config (change-theme 'solarized-light 'solarized-dark))

PS the coordinates required by theme-changer are set separately in my custom.el.

With the latest version of Emacs 29, colors like base00+1, base00-1 are much more subtle than previously. Since their values are determined by color.el methods, I first looked at the recent changes to that package. I noticed this commit and when I undo the change, compile that file and restart Emacs, the intended behavior is restored. If I modify the percentages without accounting for the Emacs version, the new theme color versions are too contrast-y on Emacs 28.

Dark theme, Emacs 29 before change:

Dark theme, Emacs 29 after change:

Dark theme, Emacs 28 before change:

Dark theme, Emacs 28 with change:

Does this theme support ledger-mode out of the box? If not, is it possible to add support for that?

This is a great theme btw!

I absolutely love this theme for Emacs, and would love an iTerm variant of the theme.

Hi isn't this issue relevant to your code?

This bug is about the light version of apropospriate-theme only.

In Magit, the background-color used of focused items seems to be not so appropriate. Here is a screenshot.

Actualy, it seem to use something that would be right in dark version, but we need something lighter for light version.

Hi,

Another thing was the background color for org-mode columnview is too light so it is hard to see:

Thank you so much!