wayfair / hypernova-php Goto Github PK

It looks like this library is not compatible with Guzzlehttp 7.x, and is still using version ^6.2 are there any chances of updating it?

 wayfair/hypernova-php dev-guzzle_5_backport requires guzzlehttp/guzzle ^5 -> satisfiable by guzzlehttp/guzzle[5.3.x-dev].
    - wayfair/hypernova-php dev-master requires guzzlehttp/guzzle ^6.2 -> satisfiable by guzzlehttp/guzzle[6.5.x-dev].
    - wayfair/hypernova-php dev-more_jobresult_fields requires guzzlehttp/guzzle ^6.2 -> satisfiable by guzzlehttp/guzzle[6.5.x-dev].
    - wayfair/hypernova-php v1.0 requires guzzlehttp/guzzle ^6.2 -> satisfiable by guzzlehttp/guzzle[6.5.x-dev].
    - wayfair/hypernova-php v1.1 requires guzzlehttp/guzzle ^6.2 -> satisfiable by guzzlehttp/guzzle[6.5.x-dev].
    - wayfair/hypernova-php v1.2 requires guzzlehttp/guzzle ^6.2 -> satisfiable by guzzlehttp/guzzle[6.5.x-dev].
    - wayfair/hypernova-php v2.0 requires guzzlehttp/guzzle ^6.2 -> satisfiable by guzzlehttp/guzzle[6.5.x-dev].
    - wayfair/hypernova-php v2.0.1 requires guzzlehttp/guzzle ^6.2 -> satisfiable by guzzlehttp/guzzle[6.5.x-dev].
    - wayfair/hypernova-php v2.1.0 requires guzzlehttp/guzzle ^6.2 -> satisfiable by guzzlehttp/guzzle[6.5.x-dev].
    - wayfair/hypernova-php v2.1.1 requires guzzlehttp/guzzle ^6.2 -> satisfiable by guzzlehttp/guzzle[6.5.x-dev].
    - Can only install one of: guzzlehttp/guzzle[7.0.x-dev, 5.3.x-dev].
    - Can only install one of: guzzlehttp/guzzle[7.0.x-dev, 6.5.x-dev].
    - Installation request for guzzlehttp/guzzle ^7.0.1 -> satisfiable by guzzlehttp/guzzle[7.0.1, 7.0.x-dev, 7.1.0, 7.1.1, 7.2.0, 7.1.x-dev].

I know you mentioned that phpv8js may not be ready for production, but since it is an in-memory solution don't you think it would be faster than Hypernova? Did you do any benchmarks to compare both?

Hello.

Great work!

I had a problem right now, where BasePlugin could not be loaded. It turns out the plugins folder is lowercase and should be Uppercase instead.

Cheers!

Description

👋 This repository is not currently configured for Renovate. This issue proposes the steps necessary to add Renovate to this project!

💡 Not familiar with Renovate, or are confused about what advantages it holds over GitHub's Dependabot? Learn more here!

Steps to Add

1. Review the guide for Adding Renovate to Existing Projects.
2. Add a comment to this issue as a signal to others that you intend to work on it. The OSPO will then assign the issue to you. If you ultimately decide not to pursue this, please remember to let us know via comment so that others may participate!
3. If the renovate[bot] account has already auto-filed a Configure Renovate PR against this repository, feel free to reference the proposed changes in your own Pull Request. If you are contributing to this project as a Hacktoberfest participant, you must file your own PR in order to get credit for your contribution!
4. You may find that the CI build for this project is failing for unrelated reasons. If you are not already a contributor to this project and don't feel comfortable attempting to fix the build, that's okay! There's plenty of other ways you can contribute to Wayfair's open source projects :) Feel free to consult the list of our other participating repositories here!
5. In order to catch potential JSON syntax errors or other mis-configurations, please add Renovate linting to this project's existing GitHub Workflow CI pipeline, or create a new one (eg. .github/workflows/lint.yml). See here for an example.
6. If this repository is currently configured to use GitHub's Dependabot, you must also deprecate support for Dependabot in order to avoid conflicts with Renovate. This is typically as simple as removing the .github/dependabot.yml file. See here for an example.

Checklist

• I have read the Adding Renovate to Existing Projects guide.
• I have assigned this issue to myself avoid duplicating efforts with other potential contributors.
• I have verified this repository does not already have Renovate configured (or proposed in an open PR by another contributor).
• If the renovate[bot] account has already auto-filed a Configure Renovate PR in this repository, I confirm that I will create a separate PR under my own GitHub account, using the initial PR as inspiration.
• I confirm that I have added Renovate linting to this project's existing CI pipeline, or have created a new linting workflow if one doesn't already exist.
• If this repository is currently configured to use GitHub's Dependabot, my PR will also deprecate support for Dependabot in order to avoid conflicts with Renovate.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update suzuki-shunsuke/github-action-renovate-config-validator action to v0.1.3
• Update GitHub Actions (major) (actions/checkout, suzuki-shunsuke/github-action-renovate-config-validator)

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Hi,
The getFallbackHTML method does not escape the json for html here. It should escape the json before sprintf-ing it into html tags just like its js counterpart here.

I'd be happy to contribute if PRs are welcome.

Here's the annotation:
https://github.com/wayfair/hypernova-php/blob/master/src/Response.php#L14

here's were it actually gets populated.
https://github.com/wayfair/hypernova-php/blob/master/src/Renderer.php#L198

Shall we change the type to string?