wardbox / spotishell Goto Github PK

First of all, amazing work on this module! I found one small easy to fix bug.

In the function for Set-ShufflePlayback you are attempting to convert a Boolean to lower. Need to convert System.Boolean to string then convert to lower.
Example Fix:
$Uri = 'https://api.spotify.com/v1/me/player/shuffle?state=' + $State.ToString().ToLower()

Describe the bug
When using Set-PlaylistItems with more than 100 tracks to add, the playlist only contains the last batch.

To Reproduce
Steps to reproduce the behavior:

1. Create a playlist
2. Add 120 tracks with Set-PlaylistItems
3. Only 20 tracks will be on the playlist

Expected behavior
All tracks should be in the playlist

Desktop (please complete the following information):

• OS: Windows 10
• Powershell Version : 5.1

Lot of functions uses $IsWindows, $IsMacOS and $IsLinux.
Those are shipped with PowerShell Core 6 and PowerShell 7

The psd1 file indicates:

# Minimum version of the Windows PowerShell engine required by this module
    PowerShellVersion = '5.0'

and then on a Powershell 5.1, the code bellow do anything, because all $Is... are $null and no browser opens up :

if ($IsMacOS) {
    # opens the constructed uri in default browser on mac
    Write-Verbose "We are on Mac OS"
    open $URI
  } elseif ($IsWindows) {
    Write-Verbose "We are on Windows"
    rundll32 url.dll,FileProtocolHandler $URI
  }

Is it possible to get the info from fields "written by" and "produced by" in a tracks "Song credits"?

Is your feature request related to a problem? Please describe.
When fetching tracks with Get-RecentlyPlayedTracks as it is at the moment, no information regarding playback timestamp is available in spotishell, but the API does mention it being available (played_at).
A (re-)write to allow getting this information would solve the problem. The simplest change is to change $Response.items.track to $Response.items at the end of the function. But this would be a breaking change.

Describe the solution you'd like
I would like to be able to get the played_at value for each track. That way I might be able to page through my recently played tracks, using a combination of Limit and BeforeTimestamp/AfterTimestamp.

Describe alternatives you've considered
I considered adding an additional argument to Get-RecentlyPlayedTracks - something similar to a flag, eg. -ItemsNotTracks and then inside the function simply check on this, and either use the current logic when the flag is missing and then use the new logic when it is available.

$tracks = Get-RecentlyPlayedTracks #Would work as is
$items = Get-RecentlyPlayedTracks -ItemsNotTracks #would return items, which has (atleast) 2 properties: `played_at`, `track`

this should take in the album Id i think