Why

Currently, the frolint command is set up to run Prettier integrated with ESLint.

What this means is that you can use the eslint-plugin-prettier plugin to run formater as if it were acting as a linter.
This has the following concerns and ideas, which we believe should be quit in this day and age. 🤔

Idea

• When eslint-plugin-prettier was recommended, many of the editors did not support Prettier, and the idea was that you had no choice but to use them via ESLint. However, many modern editors support Prettier execution, so this concern is almost no longer a concern.

Concerns

• Running Prettier on ESLint slows it down.
• In order to run Prettier on ESLint, you need to put a layer between them, which may lead to unintended behavior.
• linter and formatter are not separated, leading to unintentional warnings in the format context as a linter warning.

The Prettier formula also recommends that in the modern era it be run alone, not on ESLint.
https://prettier.io/docs/en/integrating-with-linters.html#notes

First, we have plugins that let you run Prettier as if it was a linter rule:

• eslint-plugin-prettier
• stylelint-prettier
  These plugins were especially useful when Prettier was new. By running Prettier inside your linters, you didn’t have to set up any > new infrastructure and you could re-use your editor integrations for the linters. But these days you can run prettier --check .
  and most editors have Prettier support.

What

Remove eslint-plugin-prettier so that Prettier runs by itself.

(This change is not disruptive to the developer experience for frolint users.)

Why

I get the warning unmet peer dependency "graphql@^14.6.0 || ^15.0.0 even in projects that do not use grahpql.

Why

Our new project is using React 16.8 so we using functional component with hooks (including custom ones).
However, react-hooks is new to us so it is more likely to write some anti-patterns.
To prevent this, we want to use official lint rules.
https://reactjs.org/docs/hooks-rules.html#eslint-plugin
https://www.npmjs.com/package/eslint-plugin-react-hooks

What

Introduce official line rules for react-hooks.

Why

In the following .eslintrc, use yarn eslint . /src will work, but yarn frolint -branch master -bail will raise an error.

{
  "overrides": [
    {
      "files": [
        "*.tsx",
        "*.ts"
      ],
      "extends": "wantedly-typescript",
      "parserOptions": {
        "project": [
          "./tsconfig.json",
          "./tsconfig.eslint.json"
        ]
      }
    },
    {
      "files": [
        "*.tsx",
        "*.ts"
      ],
      "processor": "@graphql-eslint/graphql"
    },
    {
      "files": [
        "./src/profile/components/profile/Sidebar/RelatedUsers/**/*.graphql"
      ],
      "parser": "@graphql-eslint/eslint-plugin",
      "parserOptions": {
        "schema": "./graphql-gateway-schema.json"
      },
      "plugins": [
        "@graphql-eslint"
      ],
      "rules": {
        "@graphql-eslint/fields-on-correct-type": [
          "error"
        ]
      }
    }
  ]
}

Internal Error: Error while loading rule '@typescript-eslint/no-floating-promises': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser.
Occurred while linting /path/to/project/src/path/to/Component.tsx/0_document.graphql

What

Why

When looking at the docs: https://prettier.io/docs/en/api.html#prettiergetfileinfofilepath--options

Setting options.ignorePath (string) and options.withNodeModules (boolean) influence the value of ignored (false by default).

The ignored will always be false if we don't give a proper ignorePath value.
But during a frolint run, the ignorePath is empty.

e.g. see debug log

  frolint:prettier Prettier config: { prettierConfig: {} } +9ms
# ↑ no `ignorePath` even though we have a .prettierignore

prettier.getFileInfo.sync(file, { ignorePath: prettierConfig.ignorePath });
// => { ignored: false, inferredParser: 'babel' } 

What

Find a way to load the .prettierignore file for the project, and convert it to a string for use as ignorePath.

Why & What

I think the following rules are conflicting between eslint and prettier.

• space-before-function-paren
  • eslint says space is required, prettier says 'no' on the other hand.
• comma-dangle
  • eslint says trailing comma is required, prettier says 'no'

😕

I found only two conflict rules so far, but maybe some more...? (I will report if I find some)

Why

NOTE: babel-eslint is now @babel/eslint-parser and has moved into the Babel monorepo.

https://github.com/babel/babel-eslint

WHY & WHAT

We can now use the no-floating-promises
typescript-eslint/typescript-eslint#495

This rule forbids usage of Promise-like values in statements without handling their errors appropriately. Unhandled promises can cause several issues, such as improperly sequenced operations, ignored Promise rejections and more. Valid ways of handling a Promise-valued statement include awaiting, returning, and either calling .then() with two arguments or .catch() with one argument

How do you think about this?
@KentoMoriwaki @chloe463 @kobayang

Why

Failed to publish eslint-plugin-wantedly package with permission denined.

lerna http fetch PUT 403 https://registry.npmjs.org/eslint-plugin-wantedly 621ms
lerna ERR! E403 You do not have permission to publish "eslint-plugin-wantedly". Are you logged in as the correct user?
error Command failed with exit code 1.

What

@yamadayuki Please add @wantedly_dev to NPM collaborators in eslint-plugin-wantedly to maintain the package.

FYI: Other frolint packages include @wantedly_dev to NPM collaborators.

Why

warning "frolint > [email protected]" has incorrect peer dependency "typescript@>=3.3.1 <4.2.0".

Why

Stop applying linter and formatter to auto-generated files

What

Handle .eslintignore and .prettierignore, or other ways