vuolen / othello-bot Goto Github PK

Great job!

Your project structure is clean and sensible. It's easy to understand what each part of the code does, and where it isn't so clear, you have commented to help with that. Your methods are descriptively named. Your tests seem good, too; you're actually testing things that matter.

One thing I would've hoped for was the possibility to stop the game in the middle instead of playing it through or closing the terminal. Also, as a friendly reminder: don't forget to write the user guide :)

Tiny things that I happened to notice while reading (don't know if you care about details like these, I just know it's practically impossible to find them all even if you did) :

• othello.bots.OthelloHuman : method isHuman() is missing @Override-annotation
• othello.bots.tiralabra.evaluators.Evaluators : variable totalDisks is not used, multiple methods' javadocs are missing @param or @return tags
• othello.bots.tiralabra.evaluators.Evaluators : again, variable totalDisks is not used
• othello.ui has two unused imports

I downloaded the project Tue 6.10.20 around 6 pm.

17.03 02.10.2020

Well thought out and well made project!

The project and all tests ran well, and coverage is very good (even though game AI is quite hard to test, you've covered the base cases well, and classes like the evaluator are thoroughly tested).
The final evaluator takes into account quite a few factors while calculating a score for the board state, which is nice.
The code overall is descriptive and well written, and the overall structure of the project seems solid.

Since the project is in such a good state I'll have to nitpick a bit here, but you could change the max method length in the checkstyle config to a more suitable number to cleanup the checkstyle-report (line 34 in checkstyle.xml).