Code Monkey home page Code Monkey logo

elevatormod's People

Contributors

abbage230 avatar alibekaytjan avatar andreaugustodev avatar blackshadow77 avatar bytegm avatar doloresmcdoodle avatar dracnis avatar felinux02 avatar fitfc avatar foxgreat avatar gcat101 avatar isocuk avatar mindy15963 avatar paintninja avatar regnander avatar vsngamer avatar xbony2 avatar zeedif avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

elevatormod's Issues

[Resource] es_MX / es_ES translation

//Translate by: Dorzar / VeryHardChamp
//Act. 30/07/2017
tile.elevator_white.name=Ascensor blanco
tile.elevator_black.name=Ascensor negro
tile.elevator_blue.name=Ascensor azul
tile.elevator_brown.name=Ascensor marrón
tile.elevator_cyan.name=Ascensor turquesa
tile.elevator_gray.name=Ascensor gris
tile.elevator_green.name=Ascensor verde
tile.elevator_light_blue.name=Ascensor azul cielo
tile.elevator_lime.name=Ascensor verde limón
tile.elevator_magenta.name=Ascensor magenta
tile.elevator_orange.name=Ascensor naranja
tile.elevator_pink.name=Ascensor rosa
tile.elevator_purple.name=Ascensor morado
tile.elevator_red.name=Ascensor rojo
tile.elevator_silver.name=Ascensor plata
tile.elevator_yellow.name=Ascensor amarillo

elevatorid.subtitle.teleport=Uso del ascensor

itemGroup.tabElevators=Elevator Mod

[1.12.1] Invalid event annotation EventHandler.

While starting a server/client, ElevatorMod is producing an error in the logs.

[10:42:43] [Server thread/ERROR] [elevatorid]: The mod elevatorid appears to have an invalid event annotation EventHandler. This annotation can only apply to methods with recognized event arguments - it will not be called
[10:42:43] [Server thread/ERROR] [elevatorid]: The mod elevatorid appears to have an invalid event annotation EventHandler. This annotation can only apply to methods with recognized event arguments - it will not be called

ElevatorMod: 1.3.4
Forge: 14.22.0.2475

Glass Elevators and Private ?

Could you please make glass variants of the Elevators - I have a glass floor in my base

Also maybe a way to make them private/public or (if FTB installed) Team only ?

Love the mod, thank you.

[Request] Slab elevators

Pretty much what it says on the title. I'd love the ability to have a half-height block that was still an elevator.

Need to handle licensing

The mod is listed as All Rights Reserved on CurseForge, and no mod pack permission is explicitly given. I also don't see the license in the source code repository. However, you state that it's a port of OpenBlocks elevators. OpenBlocks is MIT licensed, and so should your mod be, I believe.

Although it's permissive as licenses go, you do still have to include the MIT license text in the software, for example. The text of the license from OpenBlocks: https://minecraft.curseforge.com/projects/openblocks/license . And here's a Wikipedia page on it that might be of use: https://en.wikipedia.org/wiki/MIT_License

I assume you just didn't set the license on CurseForge. Won't take much at all to comply with it. I suggest setting that on CurseForge and including a copy of the license text in your source repo on Github (and no, I am not a lawyer and none of this should be construed as professional legal advice. lol). And people like me ensuring their mod pack follows all the licenses will be grateful. :)

And thanks for porting this. It's really nice to have it, and I appreciate it!

Elevator completely invisible and unaccessable

I camouflaged the elevator with a Chisel & Bits carpet like item. And now its gone, the elevator is functional and blocks the space so I cant place another block there, but not visible, accessable nor has a hitbox. In the video you can see a piston can move it and gets visivle a short time, but thats all. Now I let my Turtle from CC tweaked dig the block aaaand the server crashed, but its still there. So I have to think of something else to remove it...
But I would suggest a config file, where you can blacklist camouflag items, tags and even complete mods like Chisel & Bits.
And I play on 1.16.3

Elevator.Bug.mp4

Error while loading mod (v1.7.10, MC 1.16.3, Forge 34.1.42)

OpenBlocks Elevator version: 1.7.10
Minecraft Version: 1.16.3
Forge version: 34.1.42

I just updated OpenBlocks Elevator to the latest version (1.7.10) and now it encounters an error on startup:

Error during pre-loading phase net.minecraftforge.fml.ModLoadingException: Mod File elevatorid-1.16.4-1.7.10.jar needs language provider javafml:35 or above to load §7We have found 34.1

Ability to redye elevator blocks

It would be nice to be able to repurpose an elevator with a new dye. The following code works in 1.11.2 but doesn't work in 1.12 due to the new .json format recipes. The code must be inserted into ModCrafting.java inside the existing for loop.

for (EnumDyeColor elevatorColor : EnumDyeColor.values()) {
	GameRegistry.addShapelessRecipe(new ItemStack(ModItems.elevators.get(color)),
			new ItemStack(ModItems.elevators.get(elevatorColor)),
			// Wool, glass, and clay use the damage color
			new ItemStack(Items.DYE, 1, color.getDyeDamage())
	);
}

Interaction Bits from mod: Chisels and Bits

Elevators can get the appearance of blocks by right clicking with a block in hand. However this doesn't work with bits and leads to what is essentially a chunkban.

To Reproduce
Steps to reproduce the behavior:

Put an elevator block in the world
Rightclick the elevator with a bit from chisels and bits in hand (possibly same with bigger pieces from the mod)
Your client will kick you and unless you are still in the area upon relogging it will keep kicking you.

Expected behavior
Either get the appearance of the bit or have nothing happen.

Use BlockStates instead of many different blocks

Using unique blocks for each color of teleporter is redundant, since color functionality is available through properties. Wool uses the color property, and you can learn more about them here.

I'm new to Minecraft modding, so I'm not entirely confident yet, but I could try my hand at fixing it and allow worlds to be migrated using the MissingMappings event. If you want, I'll make a pull request with my attempts so you can look over it.

EDIT: I'm also using the Minecraft Modding plugin for Intellij IDEA, which highlights a bunch of common errors and speeds up modding a lot, so if you use Intellij you should definitely check that out.

Dedicated Server Crash ElevatorMod-1.12.2-1.3.7

Latest Update crashes Dedicated Server on Startup

ElevatorMod-1.12.2-1.3.7.jar

---- Minecraft Crash Report ----
// My bad.

Time: 2019-02-21 17:04:59 EST
Description: Exception in server tick loop

net.minecraftforge.fml.common.LoaderException: java.lang.ClassNotFoundException: xyz.vsngamer.elevator.ElevatorMod$ServerProxy
    at net.minecraftforge.fml.common.ProxyInjector.inject(ProxyInjector.java:102)
    at net.minecraftforge.fml.common.FMLModContainer.constructMod(FMLModContainer.java:598)
    at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
    at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
    at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
    at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
    at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
    at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
    at com.google.common.eventbus.EventBus.post(EventBus.java:217)
    at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:219)
    at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:197)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
    at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
    at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
    at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
    at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
    at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
    at com.google.common.eventbus.EventBus.post(EventBus.java:217)
    at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:136)
    at net.minecraftforge.fml.common.Loader.loadMods(Loader.java:593)
    at net.minecraftforge.fml.server.FMLServerHandler.beginServerLoading(FMLServerHandler.java:98)
    at net.minecraftforge.fml.common.FMLCommonHandler.onServerStart(FMLCommonHandler.java:333)
    at net.minecraft.server.dedicated.DedicatedServer.init(DedicatedServer.java:125)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:486)
    at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ClassNotFoundException: xyz.vsngamer.elevator.ElevatorMod$ServerProxy
    at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:191)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
    at net.minecraftforge.fml.common.ModClassLoader.loadClass(ModClassLoader.java:75)
    at java.lang.Class.forName0(Native Method)
    at java.lang.Class.forName(Class.java:348)
    at net.minecraftforge.fml.common.ProxyInjector.inject(ProxyInjector.java:85)
    ... 31 more
Caused by: java.lang.NullPointerException

Elevators work for spectators

Not sure if this is intended, unintended, or a bug, but if you go into spectator mode and fly up or down through an elevator block, the block will be activated. I don't know if non-spectator players on a server would hear the whoosh sound.

Discovered in ElevatorMod-1.12.2-1.3.5.jar, in Direwolf20 1.12 Pack v1.3.0

Weird Texture Disappearance Issue

Hello, this issue appears to occur when elevators from this mod are placed. As you can see I am able to look through the ground, and blocks such as glass, beds, plants, torches, crops, water, etc. completely disappear. This only occurs when looking in the direction of an elevator(s) and while the chunks with said elevator(s) are loaded. The mod version is the latest, being 1.7.13 for game version 1.16.5. Thank you for your time.
2021-06-21_23 35 11

Edit: I am using the modpack "Better Minecraft" with additional mods (cc-tweaked, immersive engineering, inventory tweaks, journeymap, pam's harvestcraft, refined storage, optifine)

Elevator skips floors

If you have 3 elevator blocks vertically, and the top pair have 2 air blocks between them, pressing shift on the top one will send you down 2 floors.

[Bug/suggestion] Skip or lock invalid elevator targets

Unsure if this is the intended behaviour or a bug/oversight. When you try to teleport and the next elevator is an invalid target (solid block/suffocating), instead of not teleporting at all, you teleport to the further next available elevator.

This prevents you from "locking"the elevators, and therefore constitutes a security breach in which any other player can add an elevator block to your own chain, and access restricted areas. Take a look at this scenario for a better explanation: https://imgur.com/a/Ek8DDtd. Imagine the wooden structure is your secured house (probably with mods like SecurityCraft). In the current version, if a hostile player puts the green elevator, he can directly access your theoretically secured area, by skipping the invalid red elevator and going down straight to the middle gray one. With the suggestion, such player would try to teleport down, but since the red elevator is unreachable, he just wouldn't teleport at all, preventing unauthorized access.

Let me know your thoughts. I'm providing a PR with these changes, that can be customized in the config in case anyone prefers the current behaviour.

(Of course unauthorized use of elevator could also be achieved by implemented private/public/team elevators, this is just a simple workaround)

Interaction Botania

interaction between elevator and botania's globetrotter sash causes the elevator to only work sometimes

MC 1.16.1

CTM mod incompatibility

When using connected textures (CTM mod, not OptiFine), elevators disguising as a block do not connect to other blocks. I've been informed by tterrag (CTM developer) that you are missing a call to model.getModelData.

Mod version: 1.16.5-1.7.12
CTM version: MC1.16.1-1.1.2.6

Screenshot of glass camouflaged elevator not connecting

ClassInheritanceMultiMap asynchronously.

Not really sure if I should report this here or not however. I get this spammed on console from time to time. And it references this mod.

[java.lang.Thread:dumpStack:1336]: at xyz.vsngamer.elevator.network.TeleportHandler.onMessage(TeleportHandler.java:35)
[java.lang.Thread:dumpStack:1336]: at xyz.vsngamer.elevator.network.TeleportHandler.onMessage(TeleportHandler.java:17)

Just tested again the spam does indeed come from the elevator mod being used.
Using spongeforge version 1.12.2-2838-7.1.7-RC3866

Glist: Full output

Error lines during initialization

21:14:18] [main/TRACE] [elevatorid/elevatorid]: Sending event FMLConstructionEvent to mod elevatorid
[21:14:18] [main/ERROR] [elevatorid/elevatorid]: The mod elevatorid appears to have an invalid event annotation EventHandler. This annotation can only apply to methods with recognized event arguments - it will not be called
[21:14:18] [main/ERROR] [elevatorid/elevatorid]: The mod elevatorid appears to have an invalid event annotation EventHandler. This annotation can only apply to methods with recognized event arguments - it will not be called

Using latest version.

Should i be worried of world corruption or ingame apocalypse?

Change Elevator Texture

A way to change the texture of elevators to mimic any block's texture when shift right click with any block (Carbs05641).

Elevator blocks not showing up in creative, or tabs

elevator problem

No idea what's happened here, but I downloaded the mod, put it in my mods folder, logged in (Forge: 28.0.45, Minecraft: 1.14.4, mod version: ElevatorMod-1.14.4-1.3.11) and I opened the inventory, scrolled to the blank tab and... yeah. Sorry. Not sure what other information you need.

I currently have the following mods:
mods so far

eta: I don't think this is an issue with your mod, but Forge or myself, because now the same thing has happened to two other mods...
forbidden_arcanus-1.14.4-1.0-Beta-2
stal111/Forbidden-Arcanus#9 (comment)
arcanus missing
compressed_items-1.14.4-1.0
stal111/Compressed-Items#2 (comment)
compressed missing
I'm not sure what the issue is... Is one meant to delete config. files when updating a mod?
Sorry to be a bother.

Elevators only work if they’re the same colour

Is this intended? I like matching the elevator with the floor, so I like having different coloured elevators, but that doesn’t work.

It’d be fantastic if you could use different coloured elevator blocks!

Minecraft version: 1.12.2
Forge version: 14.23.0.2552
OpenBlocks Elevator version: 1.3.5

Crash on server load 1.6.0

MC Version: 1.15.2
Forge version: 31.1.1
Mod list: Only this (open elevtor 1.6.0 for 1.15.2)
Java version: 1.8.0 - 231, Windows

receiving this error on load
[08:12:12] [Server thread/INFO] [minecraft/DedicatedServer]: Starting minecraft server version 1.15.2
[08:12:12] [Server thread/ERROR] [ne.mi.fm.ja.FMLModContainer/LOADING]: Failed to load class xyz.vsngamer.elevatorid.ElevatorMod
java.lang.NoClassDefFoundError: net/minecraft/client/renderer/color/IBlockColor
at java.lang.Class.forName0(Native Method) ~[?:1.8.0_231] {}
at java.lang.Class.forName(Unknown Source) ~[?:1.8.0_231] {}
at net.minecraftforge.fml.javafmlmod.FMLModContainer.<init>(FMLModContainer.java:71) ~[?:31.1] {re:classloading}

Elevators treat vanilla barrier blocks as non-solid blocks.

The ability to elevator up into non-solid blocks is cool in some circumstances, because it lets you decorate and hide elevators, but barrier blocks are intended to block player movement for a reason, and this can cause issues.

One example of this in Sky Factory 4's compact machines world type, the Twilight Forest is a compact machine cube at the world height limit, and the top of it is a layer of barrier blocks. However, if a player places an elevator as high as they can, and then rides the elevator up, they're able to do so successfully, clipping into the barrier block. Then all they have to do is jump once to be on top of it, and run around freely.

The main fix that needs to be done here is to block elevators from letting people warp into barrier blocks.

To build on this, a blacklist in the config would be nice incase something similar comes up in the future, it would allow for modpack developers to block warping into specific types of blocks that might be used in specific ways.

Invite you and your Minecraft Modification to introduce to the player/audience in Taiwan.

Hello! We are the Cite Media Holding Group. a publisher in Taiwan. For now we’re devoted to Minecraft promotion, Our company is expected to publish a book entitled <The 100 Most Favorite Minecraft Modification for Game Talents> (tentative title) in December. And we will invite well-known Minecraft Game Talents in Taiwan to carefully select the 100 most recommended Minecraft Modification in the world and introduce them to readers with words and pictures. We think that the Modification of Minecraft you created is quite rich in content and suitable for being selected in the 100 recommended lists. To publish this book, we need to obtain your consent to capture the pictures of your game (less than 10, hereinafter referred to as the authorization target) so that vast readers of Minecraft can understand your work through the introduction of this book. Neither party has to pay the fee for this authorization, but in order to protect the rights and interests of both parties, this email will be used as the basis for authorization that you agree to authorize our company to use the authorization target free of charge in <The 100 Most Favorite Minecraft Modification for Game Talents> (tentative name) by means of, but not limited to, reproducing, distributing and public transferring. If you agree to the authorization, please reply to this email directly and fill in the following information (the following information is only for future reference of the authorizers and sending books, which will not be used for other purposes) to just inform us that you "agree to authorize the pictures free of charge". If you would like to provide your address, we would be very happy to present you a book in return after it is published.

Cite Media Holding Group
Vice General Manager
Daniel Wang

Add:10F, No.141, Sec 2, Misheng E. Rd., Thongshan Distric, Taipei City 10483, Taiwan (R.O.C.)
E-MAIL:
[email protected]

TEL:(02)2500-7600 ext.2670 MOB:0916-252-365

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.