Code Monkey home page Code Monkey logo

website's People

Contributors

freezy avatar renovate-bot avatar renovate[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

Forkers

imgbotapp

website's Issues

TypeError: undefined is not a function

View details in Rollbar: https://rollbar.com/freezy/vpdb-website/items/14/


TypeError: undefined is not a function
  File "https://vpdb.io/releases.bundle-eac085787762.js", line 1, in new e
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in Object.invoke
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in A.instance
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in ie
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in c.$digest
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in c.$apply
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]

Remove invalid build (or tag) from persisted meta data on error

Use case:

  1. Author starts uploading a new release (or version), adds a tag or build
  2. Build gets deleted
  3. When submitting, though the tag or build isn't in the DB nor selectable anymore, it's still on local storage and will be submitted

Fix: Either check against valid IDs when rendering the page or clear local storage on error (first preferred).

Get rid of jQuery & jQuery UI

jQuery is quite large (265k, 85k minified, 30k gzipped). There only seem to be three dependencies:

TypeError: undefined is not a function

View details in Rollbar: https://rollbar.com/freezy/vpdb-website/items/19/


TypeError: undefined is not a function
  File "webpack:///./src/app/releases/list/release.list.ctrl.js", line 79, in new e
    		this.viewtype = viewTypes.includes(viewtype) ? viewtype : defaultViewType;
  File "webpack:///./node_modules/angular/angular.js", line 5117, in createInjector
            return fn.apply(self, args);
  File "webpack:///./node_modules/angular/angular.js", line 11139, in $ControllerProvider
              var result = $injector.invoke(expression, instance, locals, constructor);
  File "webpack:///./node_modules/angular/angular.js", line 10002, in $CompileProvider
                controller.instance = controller();
  File "webpack:///./node_modules/angular/angular.js", line 10410, in $CompileProvider
                afterTemplateNodeLinkFn(afterTemplateChildLinkFn, scope, linkNode, $rootElement,
  File "webpack:///./node_modules/angular/angular.js", line 17330, in qFactory
                resolvePromise(promise, fn(state.value));
  File "webpack:///./node_modules/angular/angular.js", line 17378, in qFactory
        nextTick(function() { processQueue(state); });
  File "webpack:///./node_modules/angular/angular.js", line 18514, in $RootScopeProvider
                  fn = asyncTask.fn;
  File "webpack:///./node_modules/angular/angular.js", line 18903, in $RootScopeProvider
                $rootScope.$digest();
  File "webpack:///./node_modules/angular/angular.js", line 20829, in $TimeoutProvider
            if (!skipApply) $rootScope.$apply();

Error: [$controller:ctrlreg] The controller with the name 'AboutCtrl' is not registered. https://errors.angularjs.org/1.6.10/$controller/ctrlreg?p0=AboutCtrl

View details in Rollbar: https://rollbar.com/freezy/vpdb-website/items/24/


Error: [$controller:ctrlreg] The controller with the name 'AboutCtrl' is not registered.
https://errors.angularjs.org/1.6.10/$controller/ctrlreg?p0=AboutCtrl
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in o
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in ie
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in $get.i
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in ie
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in c.$get.c.$digest

Error: [$compile:tpload] Failed to load template: https://vpdb.io/games/list/game.list-8pgxnBAV.html (HTTP status: -1 ) https://errors.angularjs.org/1.6.10/$compile/tpload?p0=https%3A%2F%2Fvpdb.io%2Fgames%2Flist%2Fgame.list-8pgxnBAV.html&p1=-1&p2=

View details in Rollbar: https://rollbar.com/freezy/vpdb-website/items/29/


Error: [$compile:tpload] Failed to load template: https://vpdb.io/games/list/game.list-8pgxnBAV.html (HTTP status: -1 )
https://errors.angularjs.org/1.6.10/$compile/tpload?p0=https%3A%2F%2Fvpdb.io%2Fgames%2Flist%2Fgame.list-8pgxnBAV.html&p1=-1&p2=
  File "https://cdnjs.cloudflare.com/ajax/libs/rollbar.js/2.3.9/rollbar.min.js", line 2, in e
  File "https://cdnjs.cloudflare.com/ajax/libs/rollbar.js/2.3.9/rollbar.min.js", line 2, in a
  File "https://cdnjs.cloudflare.com/ajax/libs/rollbar.js/2.3.9/rollbar.min.js", line 2, in s
  File "https://cdnjs.cloudflare.com/ajax/libs/rollbar.js/2.3.9/rollbar.min.js", line 2, in r
  File "https://cdnjs.cloudflare.com/ajax/libs/rollbar.js/2.3.9/rollbar.min.js", line 1, in a
  File "https://cdnjs.cloudflare.com/ajax/libs/rollbar.js/2.3.9/rollbar.min.js", line 1, in _applyTransforms
  File "https://cdnjs.cloudflare.com/ajax/libs/rollbar.js/2.3.9/rollbar.min.js", line 1, in log
  File "https://cdnjs.cloudflare.com/ajax/libs/rollbar.js/2.3.9/rollbar.min.js", line 1, in _log
  File "https://cdnjs.cloudflare.com/ajax/libs/rollbar.js/2.3.9/rollbar.min.js", line 1, in error
  File "https://cdnjs.cloudflare.com/ajax/libs/rollbar.js/2.3.9/rollbar.min.js", line 1, in error

Error: [$controller:ctrlreg] The controller with the name 'AboutCtrl' is not registered. https://errors.angularjs.org/1.6.10/$controller/ctrlreg?p0=AboutCtrl

View details in Rollbar: https://rollbar.com/freezy/vpdb-website/items/21/


Error: [$controller:ctrlreg] The controller with the name 'AboutCtrl' is not registered.
https://errors.angularjs.org/1.6.10/$controller/ctrlreg?p0=AboutCtrl
  File "webpack:///./node_modules/angular/angular.js", line 125, in minErr
        return new ErrorConstructor(message);
  File "webpack:///./node_modules/angular/angular.js", line 11112, in $ControllerProvider
              throw $controllerMinErr('ctrlreg',
  File "webpack:///./node_modules/angular/angular.js", line 10187, in $CompileProvider
            var controllerInstance = $controller(controller, locals, true, directive.controllerAs);
  File "webpack:///./node_modules/angular/angular.js", line 9957, in $CompileProvider
              elementControllers = setupControllers($element, attrs, transcludeFn, controllerDirectiv...
  File "webpack:///./node_modules/angular/angular.js", line 9311, in $CompileProvider
                nodeLinkFn(childLinkFn, childScope, node, $rootElement, childBoundTranscludeFn);
  File "webpack:///./node_modules/angular/angular.js", line 10065, in $CompileProvider
              childLinkFn(scopeToChild, linkNode.childNodes, undefined, boundTranscludeFn);
  File "webpack:///./node_modules/angular/angular.js", line 10410, in $CompileProvider
                afterTemplateNodeLinkFn(afterTemplateChildLinkFn, scope, linkNode, $rootElement,
  File "webpack:///./node_modules/angular/angular.js", line 17330, in qFactory
                resolvePromise(promise, fn(state.value));
  File "webpack:///./node_modules/angular/angular.js", line 17378, in qFactory
        nextTick(function() { processQueue(state); });
  File "webpack:///./node_modules/angular/angular.js", line 18514, in $RootScopeProvider
                  fn = asyncTask.fn;
  File "webpack:///./node_modules/angular/angular.js", line 18903, in $RootScopeProvider
                $rootScope.$digest();
  File "webpack:///./node_modules/angular/angular.js", line 12775, in $HttpProvider
              if (!$rootScope.$$phase) $rootScope.$apply();
  File "webpack:///./node_modules/angular/angular.js", line 13032, in createHttpBackend
          callback(status, response, headersString, statusText, xhrStatus);
  File "webpack:///./node_modules/angular/angular.js", line 12937, in createHttpBackend
            completeRequest(callback,

TypeError: undefined is not a function

View details in Rollbar: https://rollbar.com/freezy/vpdb-website/items/18/


TypeError: undefined is not a function
  File "webpack:///./src/app/common/util/filter-array.directive.js", line 36, in filterArray
    			if (scope.filterObjects.includes(objectId)) {
  File "webpack:///./node_modules/angular/angular.js", line 1393, in bind
                ? fn.apply(self, arguments)
  File "webpack:///./node_modules/angular/angular.js", line 10676, in $CompileProvider
          return extend(function() { return fn.apply(null, arguments); }, fn, annotation);
  File "webpack:///./node_modules/angular/angular.js", line 10682, in $CompileProvider
            linkFn(scope, $element, attrs, controllers, transcludeFn);
  File "webpack:///./node_modules/angular/angular.js", line 10071, in $CompileProvider
              invokeLinkFn(linkFn,
  File "webpack:///./node_modules/angular/angular.js", line 9311, in $CompileProvider
                nodeLinkFn(childLinkFn, childScope, node, $rootElement, childBoundTranscludeFn);
  File "webpack:///./node_modules/angular/angular.js", line 9314, in $CompileProvider
                childLinkFn(scope, node.childNodes, undefined, parentBoundTranscludeFn);
  File "webpack:///./node_modules/angular/angular.js", line 9176, in $CompileProvider
            if (compositeLinkFn) compositeLinkFn(scope, $linkNode, $linkNode, parentBoundTranscludeFn);
  File "webpack:///./node_modules/angular/angular.js", line 9567, in $CompileProvider
            return compiled.apply(this, arguments);
  File "webpack:///./node_modules/angular/angular.js", line 9354, in $CompileProvider
            return transcludeFn(transcludedScope, cloneFn, {

TypeError: Object doesn't support property or method 'find'

View details in Rollbar: https://rollbar.com/freezy/vpdb-website/items/25/


TypeError: Object doesn't support property or method 'find'
  File "webpack:///./src/app/common/releases/release.service.js", line 105, in value
    		return release.versions.find(version => version.files.filter(f => file.file.id === f.file.id).l...
  File "webpack:///./src/app/common/releases/release.service.js", line 92, in Anonymous function
    			flavorGrid[key] = {
  File "webpack:///./src/app/common/releases/release.service.js", line 101, in value
    		return orderBy(Object.keys(flavorGrid).map(e => flavorGrid[e]), 'released_at', false);
  File "webpack:///./src/app/releases/details/release.details.ctrl.js", line 170, in Anonymous function
    			this.flavorGrid = this.ReleaseService.flavorGrid(release);
  File "webpack:///./node_modules/angular-resource/angular-resource.js", line 801, in ResourceProvider
                    return value;
  File "webpack:///./node_modules/angular/angular.js", line 17330, in qFactory
                resolvePromise(promise, fn(state.value));
  File "webpack:///./node_modules/angular/angular.js", line 17317, in qFactory
      function processQueue(state) {
  File "webpack:///./node_modules/angular/angular.js", line 18514, in $RootScopeProvider
                  fn = asyncTask.fn;
  File "webpack:///./node_modules/angular/angular.js", line 18903, in $RootScopeProvider
                $rootScope.$digest();
  File "webpack:///./node_modules/angular/angular.js", line 12775, in $HttpProvider
              if (!$rootScope.$$phase) $rootScope.$apply();

Dependency deprecation warning: @types/axios (npm)

On registry https://registry.npmjs.org/, the "latest" version (v0.14.0) of dependency @types/axios has the following deprecation notice:

This is a stub types definition for axios (https://github.com/mzabriskie/axios). axios provides its own type definitions, so you don't need @types/axios installed!

Marking the latest version of an npm package as deprecated results in the entire package being considered deprecated, so contact the package author you think this is a mistake.

Affected package file(s): package.json

If you don't care about this, you can close this issue and not be warned about @types/axios's deprecation again. If you would like to completely disable all future deprecation warnings then add the following to your config:

"suppressNotifications": ["deprecationWarningIssues"]

TypeError: undefined is not a function

View details in Rollbar: https://rollbar.com/freezy/vpdb-website/items/17/


TypeError: undefined is not a function
  File "webpack:///./src/app/releases/list/release.list.ctrl.js", line 79, in new e
    		this.viewtype = viewTypes.includes(viewtype) ? viewtype : defaultViewType;
  File "webpack:///./node_modules/angular/angular.js", line 5117, in createInjector
            return fn.apply(self, args);
  File "webpack:///./node_modules/angular/angular.js", line 11139, in $ControllerProvider
              var result = $injector.invoke(expression, instance, locals, constructor);
  File "webpack:///./node_modules/angular/angular.js", line 10002, in $CompileProvider
                controller.instance = controller();
  File "webpack:///./node_modules/angular/angular.js", line 10410, in $CompileProvider
                afterTemplateNodeLinkFn(afterTemplateChildLinkFn, scope, linkNode, $rootElement,
  File "webpack:///./node_modules/angular/angular.js", line 17330, in qFactory
                resolvePromise(promise, fn(state.value));
  File "webpack:///./node_modules/angular/angular.js", line 17378, in qFactory
        nextTick(function() { processQueue(state); });
  File "webpack:///./node_modules/angular/angular.js", line 18514, in $RootScopeProvider
                  fn = asyncTask.fn;
  File "webpack:///./node_modules/angular/angular.js", line 18903, in $RootScopeProvider
                $rootScope.$digest();
  File "webpack:///./node_modules/angular/angular.js", line 12775, in $HttpProvider
              if (!$rootScope.$$phase) $rootScope.$apply();

ReferenceError: Can't find variable: ga

View details in Rollbar: https://rollbar.com/freezy/vpdb-website/items/28/


ReferenceError: Can't find variable: ga
  File "webpack:///./src/app/common/user/user.merge.modal.pug", line 1, in e
    module.exports = __webpack_public_path__ + "common/user/user.merge.modal-6J7QZe4V.html";
  File "[native code]", line unknown, in e
  File "webpack:///./node_modules/angular/angular.js", line 34880, in instantiate
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in [anonymous]
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in invoke
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in [anonymous]
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in invoke
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in [anonymous]
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in s
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in u
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in instantiate
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in [anonymous]
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 32353, in ngRepeatCompile
              for (index = 0; index < collectionLength; index++) {
  File "webpack:///./node_modules/angular/angular.js", line 34880, in [anonymous]
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in Pe
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in ie
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in [anonymous]
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in [anonymous]
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in [anonymous]
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 33761, in E
        return $element[0].options[0] === self.unknownOption[0];
  File "webpack:///./node_modules/angular/angular.js", line 33708, in configUpdated
        optionsMap.set(value, count + 1);
  File "webpack:///./node_modules/angular-timeago/dist/angular-timeago.js", line 604, in link
          scope.$watch('fromTime', function() {
  File "[native code]", line unknown, in forEach
  File "webpack:///./node_modules/angular-timeago/dist/angular-timeago.js", line 597, in sync
          format: '@'
  File "webpack:///./node_modules/angular/angular.js", line 26481, in a
    var ngValueDirective = function() {
  File "webpack:///./node_modules/@uirouter/core/lib/transition/transitionService.js", line 173, in invokeHook
            this._defineEvent('onEnter', Phase.RUN, 300, paths.entering);
  File "webpack:///./node_modules/@uirouter/core/lib/transition/transitionService.js", line 159, in [anonymous]
            return new transition_1.Transition(fromPath, targetState, this._router);
  File "[native code]", line unknown, in forEach
  File "webpack:///./node_modules/@uirouter/core/lib/transition/transitionService.js", line 158, in runAllHooks
        TransitionService.prototype.create = function (fromPath, targetState) {
  File "webpack:///./node_modules/oclazyload/dist/ocLazyLoad.js", line 497, in getModule
                            if (/No module/.test(e) || e.message.indexOf('$injector:nomod') > -1) {
  File "webpack:///./node_modules/angular/angular.js", line 34880, in [anonymous]
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in [anonymous]
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in $digest
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in $apply
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in [anonymous]
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in x
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "webpack:///./node_modules/angular/angular.js", line 34880, in onload
    !window.angular.$$csp().noInlineStyle && window.angular.element(document.head).prepend('<style ty...
  File "https://cdnjs.cloudflare.com/ajax/libs/rollbar.js/2.3.9/rollbar.min.js", line 1, in _rollbar_wrapped

Error: Invalid argument.

View details in Rollbar: https://rollbar.com/freezy/vpdb-website/items/31/


Error: Invalid argument.
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in Anonymous function
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in Anonymous function
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in Anonymous function
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in c.prototype.$digest
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in c.prototype.$apply
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in Anonymous function
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in x
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in $.onload

Measure performance impact of inlining above-the-fold CSS

Given that JavaScript takes a lot more time to process than CSS, this probably won't give a significant boost of loading time. However, it's still worth a try. CSS could be extracted with Puppeteer:

const puppeteer = require('puppeteer');

(async () => {

	const url = 'http://localhost:3333';
	const browser = await puppeteer.launch();
	const page = await browser.newPage();

	try {
		// enable coverage
		await page.coverage.startCSSCoverage();

		// load page
		console.log('Opening page at %s...', url);
		await page.goto(url, { waitUntil: 'load' });

		const coverage = await page.coverage.stopCSSCoverage();

		let totalBytes = 0;
		let usedBytes = 0;
		for (const entry of coverage) {
			console.log('# ================ %s ================', entry.url);
			for (const range of entry.ranges) {
				console.log(entry.text.substring(range.start, range.end));
			}
		}
		console.log('Done!');
		await browser.close();

	} catch (err) {
		if (argv.screenshots) {
			await page.screenshot({ path: 'error.png' });
		}
		console.log('ERROR: ', err);
		await browser.close();
		process.exit(1);
	}
})();

However, to do this correctly, the viewport should also be resized, and links should be at least hovered over to get the interactive styles as well.

Add verification info page

Verified Releases

A verified release means that the table is implementing controller.vbs, a script included in the Visual Pinball package. It's the way to define the controller used by the table at runtime.

Implementation

There two possibilities:

  1. Through the controller object:
    • vpinmame.controller for ROM tables
    • proc.controller for P-PROC tables
    • No controller for original tables
  2. Through B2S Server:
    • b2s.server for users with a second screen for an active backglasse and/or force feedback (DOF).

For ROM tables, b2s.server communicates with VPinMAME directly. For P-PROC, use an additional b2s.server along with the existing proc.controller.

In short, controller.vbs will instantiate and use b2s.server if it is installed and registered, and the Disable B2S option is not deactivated in the VP menu (see Keys, Nudge and DOF menu below)

The menu to define the controller.vbs is available in the VPX 10.2 options, under Preferences, Keys, Nudge and DOF:

vp-prefs

If you use a previous version of Visual Pinball, the menu is not there but you can access the options from the Windows registry (type regedit from a command line) at that location:

[HKEY_CURRENT_USER\SOFTWARE\Visual Pinball\Controller]

regedit

Controller Options

The options control the desired effect when sounds are triggered by the table, some are quite explicit like Knocker, Bell, Shaker, Gear (name of the toy that emulates the movement of objects in the playfield, like the hand of Addam’s Family), but most of the sounds are emulated by the contactors, three new options have been created in VPX 10.2 for more flexibility for the users.

The possible values for these options :

  • SoundFX or 0, activates the digital sound only
  • DOF or 1, activates the force feedback only
  • Both or 2, activates digital sound and force feedback

To not encounter problems with wrong controller.vbs from previous VP versions, it is recommended to have the VP Scripts inside the Scripts folder of VP, and no .vbs in any table folder. The latest VBS scripts are compatible for any VP version.

DOFFlippers

Some users have contactors but don’t have flipper contactors, so the control of the sound/force feedback is separated from the contactor handling.

DOFTargets

Some users prefer not to have force feedback with ball touching targets while they have force feedback with contactors..

DOFDropTargets

Same as above, when ball touches drop targets.

DOFContactors:

Used for most of the mech sounds, bumpers, slingshots, ball release, kicker holes, digital plunger, auto-plunger, diverters, drop target reset. It is DOF emulated by contactor or solenoid toys.

DOFBell:

Emulate the Bell sound, or the Bell Toy

DOFChimes:

Emulate the Chimes sound, or the Chime Toys, mostly for EM tables

DOFGear:

Emulate the sound of moving objects in the playfield, or the Gear Toy

DOFKnocker:

Emulate the knocker sound or toy

DOFShaker:

Emulate the shaker sound or toy

Disable B2S

Force controller.vbs to not use B2S Server but use VPinMAME, P-PROC or no controller depending on the table.

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

  • chore(deps): replace dependency babel-eslint with @babel/eslint-parser
  • chore(deps): replace dependency faker with @faker-js/faker
  • chore(deps): replace dependency npm-run-all with npm-run-all2 5.0.0
  • chore(deps): update node.js to d95f559
  • chore(deps): update dependency @types/jasminewd2 to v2.0.13
  • chore(deps): update dependency @types/lodash to v4.14.202
  • chore(deps): update dependency @types/pngjs to v3.4.2
  • chore(deps): update dependency @types/stream-to-array to v2.3.3
  • chore(deps): update dependency lodash-webpack-plugin to v0.11.6
  • chore(deps): update dependency parse-uri to v1.0.9
  • chore(deps): update dependency protractor to v5.4.4
  • chore(deps): update dependency svgo-loader to v2.2.2
  • chore(deps): update dependency traverse to v0.6.8
  • chore(deps): update dependency webpack-cli to v3.3.12
  • chore(deps): update angularjs monorepo to v1.8.3 (angular-animate, angular-resource, angular-sanitize, angular-touch)
  • chore(deps): update dependency angularjs-slider to v7.1.0
  • chore(deps): update dependency babel-eslint to v10.1.0
  • chore(deps): update dependency babel-loader to v8.3.0
  • chore(deps): update dependency copy-webpack-plugin to v5.1.2
  • chore(deps): update dependency draggabilly to v2.4.1
  • chore(deps): update dependency ng-annotate-loader to v0.7.0
  • chore(deps): update dependency nib to v1.2.0
  • chore(deps): update dependency rollbar-sourcemap-webpack-plugin to v2.12.0
  • chore(deps): update dependency stylus to v0.62.0
  • chore(deps): update dependency svg-sprite-loader to v4.3.0
  • chore(deps): update dependency webpack to v4.47.0
  • chore(deps): update dependency webpack-bundle-analyzer to v3.9.0
  • chore(deps): update dependency webpack-dev-server to v3.11.3
  • chore(deps): update node.js to v8.17
  • chore(deps): update dependency @types/pngjs to v6
  • chore(deps): update dependency autoprefixer to v10
  • chore(deps): update dependency babel-loader to v9
  • chore(deps): update dependency bootstrap to v5
  • chore(deps): update dependency copy-webpack-plugin to v12
  • chore(deps): update dependency cross-env to v7
  • chore(deps): update dependency css-loader to v6
  • chore(deps): update dependency draggabilly to v3
  • chore(deps): update dependency eslint to v8
  • chore(deps): update dependency faker to v6 (faker, @types/faker)
  • chore(deps): update dependency fg-loadcss to v3
  • chore(deps): update dependency file-loader to v6
  • chore(deps): update dependency html-webpack-plugin to v5
  • chore(deps): update dependency imagesloaded to v5
  • chore(deps): update dependency jasmine to v5 (jasmine, @types/jasmine)
  • chore(deps): update dependency less to v4
  • chore(deps): update dependency less-loader to v12
  • chore(deps): update dependency pngjs to v7
  • chore(deps): update dependency postcss-loader to v8
  • chore(deps): update dependency protractor to v7
  • chore(deps): update dependency raw-loader to v4
  • chore(deps): update dependency rollbar-sourcemap-webpack-plugin to v3
  • chore(deps): update dependency showdown to v2
  • chore(deps): update dependency style-loader to v3
  • chore(deps): update dependency stylus-loader to v8
  • chore(deps): update dependency svg-sprite-loader to v6
  • chore(deps): update dependency svgo to v3
  • chore(deps): update dependency svgo-loader to v4
  • chore(deps): update dependency terser-webpack-plugin to v5
  • chore(deps): update dependency timeago.js to v4
  • chore(deps): update dependency typescript to v5
  • chore(deps): update dependency url-loader to v4
  • chore(deps): update dependency webpack to v5
  • chore(deps): update dependency webpack-bundle-analyzer to v4
  • chore(deps): update dependency webpack-cli to v5
  • chore(deps): update dependency webpack-dev-server to v5
  • chore(deps): update dependency webpack-merge to v5
  • chore(deps): update dependency webpack-sources to v3
  • chore(deps): update dependency workbox-webpack-plugin to v7
  • chore(deps): update node.js to v17
  • chore(deps): update node.js to v20
  • 🔐 Create all rate-limited PRs at once 🔐

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Detected dependencies

circleci
.circleci/config.yml
  • circleci/node 8.16-stretch@sha256:01213aaa128bbe2697cc040ef815e61591a1d16a94876032db6117e5003f34da
npm
package.json
  • @uirouter/angularjs 1.0.23
  • angular 1.7.9
  • angular-animate 1.7.9
  • angular-elastic 2.5.1
  • angular-gravatar 0.4.2
  • angular-resource 1.7.9
  • angular-sanitize 1.7.9
  • angular-touch 1.7.9
  • angular-ui-bootstrap 2.5.6
  • angularjs-slider 7.0.0
  • bootstrap 3.4.1
  • draggabilly 2.2.0
  • fg-loadcss 2.1.0
  • imagesloaded 4.1.4
  • lodash 4.17.15
  • ment.io 0.9.23
  • ng-file-upload 12.2.13
  • ngclipboard 2.0.0
  • ngstorage 0.3.11
  • oclazyload 1.1.0
  • parse-uri 1.0.0
  • showdown 1.9.1
  • three 0.105.2
  • timeago.js 3.0.2
  • traverse 0.6.6
  • video.js 6.9.0
  • videojs-sublime-skin 1.0.3
  • @babel/core 7.7.2
  • @babel/preset-env 7.7.1
  • @types/faker 4.1.7
  • @types/jasmine 3.4.6
  • @types/jasminewd2 2.0.8
  • @types/lodash 4.14.149
  • @types/pngjs 3.4.0
  • @types/stream-to-array 2.3.0
  • autoprefixer 9.7.2
  • axios 0.19.0
  • babel-eslint 10.0.3
  • babel-loader 8.0.6
  • babel-plugin-lodash 3.3.4
  • copy-webpack-plugin 5.0.5
  • cross-env 5.2.0
  • css-loader 2.1.1
  • eslint 5.16.0
  • extract-text-webpack-plugin 4.0.0-beta.0
  • faker 4.1.0
  • file-loader 3.0.1
  • html-webpack-plugin 3.2.0
  • jasmine 3.4.0
  • jasmine-console-reporter 3.1.0
  • less 3.9.0
  • less-loader 5.0.0
  • lodash-webpack-plugin 0.11.5
  • ng-annotate-loader 0.6.1
  • nib 1.1.2
  • npm-run-all 4.1.5
  • pleasejs 0.4.2
  • pngjs 3.4.0
  • postcss-loader 3.0.0
  • preload-webpack-plugin 3.0.0-beta.3
  • protractor 5.4.2
  • protractor-beautiful-reporter 1.2.8
  • pug 2.0.4
  • pug-html-loader 1.1.5
  • pug-loader 2.4.0
  • raw-loader 2.0.0
  • rollbar-sourcemap-webpack-plugin 2.5.1
  • stream-to-array 2.3.0
  • style-loader 0.23.1
  • stylus 0.54.7
  • stylus-loader 3.0.2
  • svg-sprite-loader 4.1.6
  • svgo 1.2.2
  • svgo-loader 2.2.1
  • terser-webpack-plugin 1.3.0
  • typescript 3.5.2
  • url-loader 1.1.2
  • webpack 4.41.2
  • webpack-bundle-analyzer 3.6.0
  • webpack-cli 3.3.10
  • webpack-dev-server 3.9.0
  • webpack-merge 4.2.2
  • webpack-sources 1.4.3
  • workbox-webpack-plugin 4.3.1
  • node >=8.0 <9.0
travis
.travis.yml
  • node 10

  • Check this box to trigger a request for Renovate to run again on this repository

Error: Invalid argument.

View details in Rollbar: https://rollbar.com/freezy/vpdb-website/items/26/


Error: Invalid argument.
  File "webpack:///./node_modules/angular/angular.js", line 10482, in $CompileProvider
                    node[0].nodeValue = value;
  File "webpack:///./node_modules/angular/angular.js", line 13407, in $InterpolateProvider
                  listener.call(this, currValue, values !== oldValues ? lastValue : currValue, scope);
  File "webpack:///./node_modules/angular/angular.js", line 18208, in $RootScopeProvider
                listener(newValues, (value === oldValue) ? newValues : oldValues, scope);
  File "webpack:///./node_modules/angular/angular.js", line 18542, in $RootScopeProvider
                          fn = watch.fn;
  File "webpack:///./node_modules/angular/angular.js", line 18903, in $RootScopeProvider
                $rootScope.$digest();
  File "webpack:///./node_modules/angular/angular.js", line 12775, in $HttpProvider
              if (!$rootScope.$$phase) $rootScope.$apply();
  File "webpack:///./node_modules/angular/angular.js", line 13032, in createHttpBackend
          callback(status, response, headersString, statusText, xhrStatus);
  File "webpack:///./node_modules/angular/angular.js", line 12937, in createHttpBackend
            completeRequest(callback,

TypeError: undefined is not a function

View details in Rollbar: https://rollbar.com/freezy/vpdb-website/items/15/


TypeError: undefined is not a function
  File "https://vpdb.io/app.bundle-6155c5da8254.js", line 1, in e.n.value
  File "https://vpdb.io/app.bundle-6155c5da8254.js", line 1, in [anonymous]
  File "(native)", line unknown, in Array.forEach
  File "https://vpdb.io/app.bundle-6155c5da8254.js", line 1, in e.n.value
  File "https://vpdb.io/releases.bundle-eac085787762.js", line 1, in [anonymous]
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in c.$digest
  File "https://vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in c.$apply

TypeError: undefined is not a function

View details in Rollbar: https://rollbar.com/freezy/vpdb-website/items/23/


TypeError: undefined is not a function
  File "https://staging.vpdb.io/app.bundle-f78c36b2a6ec.js", line 1, in e.n.value
  File "https://staging.vpdb.io/app.bundle-f78c36b2a6ec.js", line 1, in [anonymous]
  File "(native)", line unknown, in Array.forEach
  File "https://staging.vpdb.io/app.bundle-f78c36b2a6ec.js", line 1, in e.n.value
  File "https://staging.vpdb.io/releases.bundle-eac085787762.js", line 1, in [anonymous]
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in [anonymous]
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in c.$get.c.$digest
  File "https://staging.vpdb.io/vendor.bundle-22196e1ff20a.js", line 1, in c.$get.c.$apply

Make the webapp file system aware

Lots of cool stuff could be done by giving the browser access to the file system, such as:

  • Tag locally available files when browsing
  • Filter by local availability
  • Download directly to the right place instead of a .zip file
  • Make it easier to upload stuff (faster selection, grab available media)
  • Update PinballX.xml after download

For reading and parsing it's probably a good idea to use a web worker.

Lazy-load Bootstrap templates

Now we include everything, resulting in 123k (minified, 32k gzipped) worth of JavaScript. We should be lazy-loading components individually in order to reduce initial load time.

It's documented how to do that quite well here.

Add better permission handling

Instead of just hiding links, also check on the page if the user has the permission to use it instead of relying on the backend to refuse.

Also behave accordingly if the user's access token is for some reason invalid.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.