trapperkeeper augeas lens fails for ruby-load-path about puppet-puppetserver HOT 10 CLOSED

changing let rec entry = hash (entry|simple|array) to let rec entry = hash (simple|array) will make it work correctly on ruby-load-path in puppetserver.conf but breaks with on ca.conf which has nested hashes so to say.

from puppet-puppetserver.

Would this solve setting puppet-admin/client-whitelist to an array, too? Currently, this doesn't work, too (and I am really bad at writing lenses...)

from puppet-puppetserver.

@mmckinst @poikilotherm

In order to fix #7 I just commited a big change that remaps the entire lens and types every entry.

Therefore, entries will now be typed as either @hash or @array, which should solve that issue, too. Let me know!

from puppet-puppetserver.

@mmckinst @poikilotherm can you confirm that releaes 2.0.0 fixes that issue?

from puppet-puppetserver.

Hi @raphink, I will check on wednesday and report back as I attended a training for tomorrow.

from puppet-puppetserver.

Thank you @poikilotherm

from puppet-puppetserver.

Hi @raphink ,

the lens still is not working correctly.

Test case 1:

puppetserver::config::puppetserver { 'puppetserver.conf/puppet-admin/client-whitelist':
   value => [$::fqdn]
}

Should result in

client-whitelist: [puppetmaster.fqdn.tld]

But results in

client-whitelist:puppetmaster.fqdn.tld

which breaks puppetserver.

Test case 2:

puppetserver::config::puppetserver { 'puppetserver.conf/puppet-admin/client-whitelist':
   value => [$::fqdn, 'localhost']
}

results in

client-whitelist:[puppetmaster.fqdn.tld,localhost]

which is not very nice (missing spaces for readability) but works ok.

The indentation is not working, too. It should look like:

puppet-admin: {
    client-whitelist:[puppetmaster.fqdn.tld,localhost]
}

but it looks like

puppet-admin: {
client-whitelist:[puppetmaster.fqdn.tld,localhost]
}

from puppet-puppetserver.

@poikilotherm You need to add setting_type => array to your puppetserver::config::puppetserver resource.

from puppet-puppetserver.

Ups, I didn't see that in the docs. Adding the setting_type solves everything! Great!

I would really appreciate if the indentation issue could be fixed, too.

Thanks anyway :-)

from puppet-puppetserver.

The indentation cannot be fixed currently, due to a limitation of recursive lenses in Augeas. I could set a default indentation, but then all entries would be indented, which would be worse than none.

from puppet-puppetserver.