Comments (5)
as commented in #20 (comment) the module should maybe better not provide the repo class as the person installing puppetserver with puppet very likely already has the puppetlabs repo configured or manages packages with internal repositories.
The README.md should point to the modules providing smooth repo integration for other users to be included in profiles.
from puppet-puppetserver.
https://github.com/puppetlabs-operations/puppet-puppetlabs_apt/pull/14
from puppet-puppetserver.
$repo_class = '::puppetlabs_yum'
from puppet-puppetserver.
@juniorsysadmin repo_class ? do you mean passing repo_class to puppetserver::repository?
# example class
class puppetserver::repository( $repo_class = $puppetserver::params::repo_class ) {
include $repo_class
}
# profile
class { puppetserver::repository: repo_class => `::puppetlabs_yum` }
class { puppetserver: }
## versus
# profile
include ::puppetlabs_yum
include ::puppetserver
Class['puppetlabs_yum'] -> Class['puppetserver']
IMHO:
- puppet-puppetserver shouldn't provide the repoository config because it changes and others provide modules to provide exactly this service
- puppet-puppetserver shouldn't depend on the modules because when installing puppet-agent most people already have the repo configured and to install puppetserver with puppet one requires to install puppet before.
- puppet-puppetserver shouldn't care about puppet3 anymore because we ware puppet 4 only we don't support puppet3 anymore. (https://voxpupuli.org/blog/2016/12/22/putting-down-puppet-3/)
- puppet-puppetserver shouldn't depend on the modules because if installing puppetserver with puppet and I have only internal repositories I don't wan't to include puppet modules in my env which I will never use.
- puppet-puppetserver should provide documentation howto configure puppet repo with 3rd party modules
from puppet-puppetserver.
@vinzent Actually that's better. Can't remember the reason for filing this issue other than removing the repository class code.
from puppet-puppetserver.
Related Issues (20)
- Travis shows acceptance tests green but are not run HOT 1
- puppetserver_config/augeas provider rspec failures on travis
- Release 3.0.0 HOT 6
- Update metadata.json
- Release 2.2.0 HOT 3
- puppetserver_gem provider requires PATH to include path to puppetserver binary HOT 2
- $targetfile in puppetserver::config::bootstrap doesn't respect puppetserver 5.1.x HOT 5
- value parameter of defined type puppetserver::config::bootstrap does not seem to be used
- Add ability to configure JRUBY_JAR setting to avoid `undefined method 'keep_alive_timeout=' for #<Net::HTTP..."` errors
- Documentation on managing puppetserver configuration is inadequate
- The puppeterver class's facilities for managing config files are rigid and limited
- check debian support
- Failure while initializing puppetserver
- Ubuntu 18.04 package repo has moved from "main" to "puppet"
- Deprecate this module in favour of foreman/puppet HOT 13
- 3.0.1 tag has old keyserver for debian
- Puppet 6 should be supported HOT 2
- Puppetserver >= 6.5 does have issues with Augeas Trapperkeeper lens
- Fix 'title patterns that use procs are not supported' HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-puppetserver.