Code Monkey home page Code Monkey logo

tag-all-tabs's Introduction

Automatically exported from code.google.com/p/vovcacik

vovcacik

It´s just my personal sandbox.

tag-all-tabs's People

Contributors

vovcacik avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar

Forkers

hohoow

tag-all-tabs's Issues

NS_ERROR_ILLEGAL_VALUE from nsITaggingService::getTagsForURI at editBookmarkOverlay.js:423

Full addon review revealed this bug described by will:

However, I get the following error in the Browser Console when tagging all tabs. I think it might be the case that BookmarkPropertiesPanel._URIs has an extra null entry (in addition to all the open tabs) and the error is coming from trying to tag that null URI with PlacesUtils.tagging.tagURI(URI, tags);. Please try to fix this issue with your next update.

NS_ERROR_ILLEGAL_VALUE: 'Illegal value' when calling method: [nsITaggingService::getTagsForURI] @ chrome://browser/content/places/editBookmarkOverlay.js:423

Tested on Ubuntu 12.04, OS X 10.8.4 with Firefox 23, 24

Use MutationObserver instead of DOM mutation event.

Will pointed out this issue in full addon review:

Note that you reference a DOM mutation event. These are deprecated and usually not allowed. Yours is okay for because it mirrors the current Firefox code at http://mxr.mozilla.org/mozilla-release/source/browser/components/places/content/bookmarkProperties.js#337 . However, at some point in the future, if the Firefox code is updated, you may need to use a mutation observer instead as described here: https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.