vonvikken / svg-maps Goto Github PK

Remove relative paths from code:

• svg-maps/lib/dataset_builder.rb

  Line 71 in 72f40f1

  Dir.mkdir tmp_dir unless File.exist? tmp_dir

• svg-maps/lib/dataset_builder.rb

  Line 112 in 72f40f1

  Dir.chdir tmp_dir

• svg-maps/lib/dataset_builder.rb

  Line 130 in 72f40f1

  Dir.chdir @data_dir

• svg-maps/lib/dataset_builder.rb

  Line 170 in 72f40f1

  Dir.chdir tmp_dir

• svg-maps/lib/dataset_builder.rb

  Line 178 in 72f40f1

  Dir.chdir @data_dir

• Extract metadata from GeoJson.
• Convert the GeoJSON file to SVG.
• Remove unwanted elements from SVG.
• Add relevant info and metadata to SVG.

Add the following text: <!-- Data extracted from OpenStreetMap - https://www.openstreetmap.org/copyright --> to the generated SVG files.

Use CSS to define map style.

Use Logger facility instead of puts.

• Use script for downloading states datasets.
• Use a menu/wizard for initial configuration.
• #28

Obtain a map of a given province, with boundaries of the internal comuni and of the neighbouring administrative entities.

For example arguments and return values.

When specifying one or more foreign nations, the application crashes with the following traceback:

Traceback (most recent call last):
	6: from /home/vonvikken/svg-maps/prova.rb:35:in `<main>'
	5: from /home/vonvikken/svg-maps/lib/svg_builder.rb:40:in `build_svg'
	4: from /home/vonvikken/svg-maps/lib/svg_builder.rb:70:in `add_info_to_svg'
	3: from /home/vonvikken/.rvm/gems/ruby-2.7.0/gems/nokogiri-1.10.10/lib/nokogiri/xml/node_set.rb:237:in `each'
	2: from /home/vonvikken/.rvm/gems/ruby-2.7.0/gems/nokogiri-1.10.10/lib/nokogiri/xml/node_set.rb:237:in `upto'
	1: from /home/vonvikken/.rvm/gems/ruby-2.7.0/gems/nokogiri-1.10.10/lib/nokogiri/xml/node_set.rb:238:in `block in each'
/home/vonvikken/svg-maps/lib/svg_builder.rb:73:in `block in add_info_to_svg': undefined method `[]' for nil:NilClass (NoMethodError)

This happens because the foreign nations dataset currently have id instead of @id for the the ID field, so in the following line:

This method should have the same effect of -C option, but using an existing province map instead of the -p parameter for input.

It should be useful for specifying working directories or command line parameters (e.g. for the reprojection commands).

The maps should be copied in a folder with the same name of the province and each one should have its own comune highlighted.

Related to #13.

Hovering mouse cursor over a map feature displays its name.

• Dependencies such rake or nokogiri are not downloaded automatically.
• Directory data/out not created automatically.

Add the option to highlight a given comune in the map, provided its name or other code (e.g. ISTAT). The CSS style interest is already defined.

Script for downloading regions should be able to select only some of them (e.g. to resume a partial download).

The maps should show the coastal lagunas of Venezia (Veneto) and Grado (Friuli-Venezia Giulia), plus the two lagunas of Orbetello (Toscana) and Valli di Comacchio (Emilia-Romagna).

Those lakes should have a tooltip text on hover.

Depends on #20, since manually downloading every dataset is too boring!

• Script to download datasets.
• Add lakes to maps (optionally with the -l or --lakes flag).

Write a wiki page about the procedures and complete the Readme.

Each file can reach up to a couple of MiB in size. Provide the option to simplify the generated polygons (via the MapShaper -simplify option) and thus reduce the output size.

Dataset filenames are currently based on full region/country names, often including spaces and/or hyphens. Short names based on the corresponding codes used by the CLI should be used instead.

Add script to automate the following command:

mapshaper -i file.geojson -each 'admin_level=admin_level.toString();id=id.toString()' -o out.geojson

for each of the foreign country datasets.