volfpeter / fasthx Goto Github PK

README.md is quite good but I think there must be a folder called "examples" for fully-fledged examples with templates folder and Jinja2 templates.

Is there a way to make these decorators swagger-compliant?

Edit: The hx-request header parameter doesn't show up on the SwaggerUI.

The goal is to be able to serve "main" pages through the Jinja class.

The best solution is to let template_name be a callable that returns a string.

Hey,

would it be possible to define a template per response code? This would make it easier, to render a different template, e.g. in case of validation errors of API input or other situations (e.g. item not found ...).

I understand that it would likely also be possible to have that logic within the template (if the response object is made available), but it might be need lees boilerplate code to be able to see that directly in the Python code.

Henning

Problem statement: Unable to access Response in the route (e.g. setting cookies) as it's being handled by fasthx.

Currently using a workaround - hx-target to a hidden div for the returned JWT tokens, and use JS to detect the response code and redirect the browser.

Would be nice if we could access Response from within the route.

We can not access endpoint dependencies from Jinja templates as of now. What if we change this block:

as this:

        def render(result: Any, *, context: dict[str, Any], request: Request) -> HTMLResponse:
            result.update({"depends": context})
            return self.templates.TemplateResponse(name=template_name, request=request, context=result)

Maybe another name for the key, private instead of depends?

Hi,

As HTMX relies on returning HX-* Header for certain functionality like triggers, I was wondering how to send these with fasthx?

I tried like this, but that seems to get filtered for HTMX responses:

response.headers["HX-Trigger"] = "newPortfolio"

# Add new
@router.post("/", response_model=PortfolioCreate)
@jinja.hx("portfolios/portfolio.jinja2")
async def create(response: Response, portfolio: PortfolioCreate, db: Session = Depends(database.get_db)):
    response.headers["HX-Trigger"] = "newPortfolio"
 ...
    return record

The json response is correct though:

< HTTP/1.1 200 OK
< date: Tue, 26 Mar 2024 11:26:16 GMT
< server: uvicorn
< content-length: 38
< content-type: application/json
< hx-trigger: newPortfolio
< 
* Connection #0 to host localhost left intact
{"name":"Portfolio3","description":""}

Ollie.

To avoid locking the asyncio event loop.

Currently the route must return a dict (which is a bit hidden by the Any type).

The decorator should at least handle these cases by converting them to a dict (Jinja rendering context): dict, pydantic.BaseModel (both v1 and v2), objects with __dict__ or __slots__. Maybe Iterables should also be accepted, the Jinja context in that case could be {"items": [r for r in result]}.