vmware-archive / pop-build Goto Github PK

This issue is created to track the work to migrate salt-bin to pop-build. Investigation will need to be done to see if its better to entirely migrate salt-bin into pop-build or just make it a wrapper.

We should have the option to omit files by glob so that configs for specific platforms can remove any files that are just not needed

Feature request:

pop-build clean

pop-build clean since that would follow traditional work-flows, e.g. make clean

This effectively performs rm -fR build dist

pop-build is making use of feature introduced with Py 3.7, namely 'capture_output'.
In order to build on RHEL 7 and REHL 8 which both use Py 3.6, this needs to be changed as follows:

popbuild/popbuild/venv.py
opts = hub.popbuild.BUILDS[bname]
## root = subprocess.run('pyenv root', shell=True, capture_output=True).stdout.strip().decode()
root = subprocess.run('pyenv root', shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE).stdout.strip().decode()
avail = set()
## for line in subprocess.run('pyenv versions', shell=True, capture_output=True).stdout.strip().decode().split('\n'):
for line in subprocess.run('pyenv versions', shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE).stdout.strip().decode().split('\n'):
avail.add(line.strip())

Right now the pypi libs are all from pypi, we want to allow them to be pulled from a local source, already downloaded, or from dep packages.

hey! I installed pop-build from pypi and the python executable it installs under /usr/bin/pop-build isnt working

# install pop-build python3 package
[root@e435611070e9 salt-bin]# python3 -m pip install pop-build

# test pop-build
[root@e435611070e9 salt-bin]# /usr/local/bin/pop-build
Traceback (most recent call last):
  File "/usr/local/bin/pop-build", line 5, in <module>
    from popbuild.scripts import start
ModuleNotFoundError: No module named 'popbuild'

I do see a file scripts is under /usr/local/lib/python3.6/site-packages/pop/scripts.py but this doesnt have a start function defined

[root@e435611070e9 salt-bin]# more /usr/local/lib/python3.6/site-packages/pop/scripts.py  | grep "^def"
def pop_seed():