vmarcella / cs13 Goto Github PK

Good work on your set implementation. I believe that your is_subset function is backwards. You are actually supposed to check if self (the current set) is a subset of another passed in set.

Your tests are fine and work well for many typical cases, but you're only checking integers and strings here. You do pretty well with checking edge cases.

• Your linked list and doubly linked list methods look good. I like also like the comments you added. I don't quite get the use of Omega and Theta when talking about time complexity, but the values themselves look good.
• Your stacks and queues look good as well. Your annotations here look good as well.

Great work on your base conversion algorithms and your search functions.

Your base conversion looked really good. They are written clearly with plenty of clarifying comments. It is awesome that you got negatives and fractional values as well.

Binary search was good too!

Good job on this submission, Vincenzo! Your code is passing all tests.

Once again, good work defining consistent variables for your big O notation. Your analysis all looks correct to me.

Good job with getting the linear probing function written. One thing I don't see for this are tests. It is important to tests the new hash table as well to make sure it also works. If I'm missing where you put them, please let me know.

Your palindromes functions are good. It was a good catch to skip non-letter characters instead of changing the entire string up front.

Great work with separation of concerns for string searching. You made it easy to understand how you thought about string searching when developing your algorithm. Your time complexity analysis on your string searching algorithms is excellent. I'm glad you defined your different variables. Your added test cases in strings_test.py were pretty entertaining to read.

I didn't see an anagram checking function/file. Please tell me if I missed where you did that stretch challenge. I also didn't see any benchmarking of your string checking algorithms.