vivid-planet / comet Goto Github PK

For some cases (e.g. an "Add" page), it might be helpful to make the payload (which is basically the entity's ID) optional instead of creating Routes like /pages/add/new. What do you think?

Sorry, but I have to bring this on the table again; now we have:

import { FinalFormInput, FinalFormCheckbox } from "@vivid-planet/react-admin";

I'm not very happy with it. Another (not yet discussed) alternative could be:

import { Input, Checkbox } from "@vivid-planet/react-admin-final-form-fields";

(create an own package just for the sake of shorter exports)

This would have to stay:

import { FinalFormDatePicker } from "@vivid-planet/react-admin-date-picker";

Is used only once: https://github.com/vivid-planet/react-admin/blob/consolidate-packages/packages/react-admin/src/materialUiReactSelect/Select.tsx#L97

Quick Intro: I created a Filterbar Component for our Admin Tables. It takes Final Form Filter Fields as a prop and creates the forms to be able to apply filterValues to the TableQuery.
I already published my PR with the Variant A.

Variant A : A quick Look at my Filterbar Component and how it works.
https://user-images.githubusercontent.com/12484761/112325852-526fe980-8cb4-11eb-9d58-d384d0ccac9d.mov
(sry for the bad quality but only 10Mb allowed)

Variant B: This Variant would work like the Filtersection from Zalando. Its also not a bad idea in my opinion. There is no Sidebar and no labelValuesFunctions for the FilterFields. And their filterFields also work like my popoverFormField in Variant A so it only would take a small restyling of it.
Zalando.at

So i had a Question if my Variant makes sense or maybe its an overkill how i built it. Thats why i wanted to ask which variant is better for our Comet Admin
My main problem with Variant A is the dependency in my sidebar between my filters without immediately trigger the result of the table behind. So right now its implemented in the sidebar that you can fill your form fields in the sidebar and then submit all fields in the sidebar to the Tablequery to get new TableResults. Because there are not dependencies between my fields, it can happen that you don't get any results in your table anymore, which can be a problem for the user. And the Second problem is the performance issue you can see in the video during resizing the screen.

Variant B would still need to be implemented depending on what Result I get out of this Discussion.

Maybe even a Variant C gets revealed during the discussion i don't know but all i know its a question i cant answer alone so thats why i started this issue :)
Thank you for your attention, your time and your answers on my Topic :)

With the consolidation the importing of the former subpackages has changed. Du to naming collisions it is not possible to export everthing at root level. How should it work from now on?

Before:

import { FinalForm } from "@vivid-planet/react-admin-core";	
import { Field, FormPaper, Input } from "@vivid-planet/react-admin-form";	

1. Current Solution:

import { FinalForm, form } from "@vivid-planet/react-admin";
const { Field, FormPaper, Input } = form;

2. Export everything at root level.
Therefore we have to solve the naming collisions, e.g.:

import { FinalForm, FormField, FormPaper, FormInput } from "@vivid-planet/react-admin";	

3. We use subdirectory-imports

import { FinalForm } from "@vivid-planet/react-admin";
import {  Field, FormPaper, Input } from "@vivid-planet/react-admin/form";

This is currently not possible out of the box. If we import from "@vivid-planet/react-admin/form" the subdirectory "./form" in the "node_modules/@vivid-planet/react-admin" directory is used - which does not exist as we build into the "lib"-directory.

There are three solutions I can think of:
a. We build into the root directory. Then there is the danger of file collisions and the ./src exists in the lib. However, currently it should work and is an easy solution.
b. We write index files for every subdirectory. E.g. react-admin/form.js (and form.d.ts) which exports everything from the subdirectory. Hacky and manual solution.
c. We try to find a solution during the build process. However, I don't think that is too easy especially
when we want to keep the simple tsc compilation. Besides that there is already a standard to achieve this (https://nodejs.org/api/packages.html#packages_exports), but typescript doesn't recognize it yet (microsoft/TypeScript#33079).

Please answer with your favoured solution (1, 2, 3a, 3b, 3c).

Is it possible to remove it? Who would do it?

somehow data is an empty object ({}) and does not get catched by if (!ret.data) https://github.com/vivid-planet/react-admin/blob/master/packages/react-admin-core/src/table/useTableQuery.ts#L122, resolveTableData is called with an empty object.

is this intended?

Currently the dialog will be closed after (unsuccessful submit) which shows the save-question. Instead it should just stay open.

• ThemeAugmentation for custom styling and props
• Grid is maybe not the right component for both, the wrapper and around the children
• The empty Toolbar should not be necessary
• Default color props should not be necessary (ThemeAugmentation)
• The appBar transition is likely never used

like started for EditDialog in #224

Possible solutions:

• override style of DialogContent to overflow visible (not a good idea as it breaks longer forms where we want the scroller)
• use react portal (react-select with https://react-select.com/advanced#portaling)
• use altenative to react-select that does portaling out of the box (eg the new material-ui autocomplete)

Categorization does not reflect anymore package structure. So we could organize them as we find it logical, but maybe it stays quite the same.

I would also consider renaming just to stories so that it is immediately visible that the package does not belong to react-admin itself.

https://material-ui.com/components/autocomplete/

It's meant to be an improved version of the "react-select" and "downshift" packages.

Only a suggestion, I didn't yet really go into the details...

Didn't check out the cause yet, but already fails in current next

• Table Besides Form
• Table Besides Form Selection Hooks

when a rte-field is in a final-form, the promptmessage "Nicht gespeicherte Änderungen verwerfen?" always shows when pressing cancel even if there are no changes.

If an EditDialog is in a stack and contains a form, submitting with an Enter-Click triggers the Stack to go back one step too far.

This does not happen if the "Save" Button is used for submitting.

Example:

Original URL: /folder-1/folder/folder-2/folder/add

Submit by Enter Click:

• Expected URL: /folder-1/folder/folder-2/folder
• Actual URL: /folder-1/folder

Submit by Save-Button Click (this works as expected):

• Expected URL: /folder-1/folder/folder-2/folder
• Actual URL: /folder-1/folder/folder-2/folder

1. next branch (contains apollo 3 update, i18n, react 16 || 17) - will be merged into master and deleded after 0.1.0 release
2. 1.0.0 first version, with new name(!!!!)
3. independent
4. changelog file with highlights+incompatibilities in each package (copied into gh release)
5. merge all packages (except date+color picker + rte + stories) into one "@vivid-planet/react-admin"

e.g.

<PrettyBytes value={x} />

Returns value in fitting unit

• 1024 bytes => 1 kb
• 1.048.576 bytes => 1 mb
• 3.221.225.472 bytes => 3 gb
• ...

probably kilobyte, megabyte and gigabyte is enough

See #243 (comment)

PR should be based on #243

Remove usages in following files:

• react-admin-stories/src/react-admin-core/FormCustomButtons.tsx
• react-admin-date-picker/src/DatePicker.sc.ts
• react-admin-date-picker/src/DateRangePicker.sc.ts
• react-admin-rte/src/core/Rte.sc.ts
• react-admin-rte/src/core/Controls/BlockTypesControls.sc.ts
• react-admin-rte/src/core/Controls/ControlButton.sc.ts
• react-admin-rte/src/core/Controls/FeaturesButtonGroup.sc.ts
• react-admin-rte/src/core/Controls/LinkControls.sc.ts
• react-admin-rte/src/core/Controls/Toolbar.sc.ts

If something is missing, quote changes here, I will formulate them into CHANGELOG.md

Breaking:

• Consolidated packages to @vivid-planet/react-admin
• New versioning scheme
• react-intl
• Update apollo & graphql

Highlights:

• Hooks for EditDialog, ...

The story showing the menu is broken.

Only the collapsible items are shown (without children).

• react-admin-starter
• move into gitlab
• +api +deployment +idp +dev-setup

Inside of groups it no longer recognises the type of the state.

Project with comet "4.1.0-alpha.1557.0"