Code Monkey home page Code Monkey logo

abraflexi-raiffeisenbank's People

Contributors

vitexus avatar

Watchers

avatar avatar avatar avatar

Forkers

simonformanek

abraflexi-raiffeisenbank's Issues

Error for auto scope, when no previous transaction exists

There are probably 2 bugs

abraflexi-raiffeisenbank/src/AbraFlexi/RaiffeisenBank/Transactor.php

Line 216 in 4efcb4b

$this->until = (new \DateTime('two days ago'))->setTime(0, 0); //Now

  1. 'two days ago' should read '2 days ago' - parsing will fail here
  2. intention was probably to set it to now, not 2 days ago - current line causes 'since' grater than 'until'

IMHO, when there is no previous transaction, it would worth to set last 90 days period. since = '89 days ago', until 'now'

Error when a transaction has no remittanceInformation

When no reference or code is provided with the transaction, the "remittanceInformation" block is not present at all. (Which is different behavior to e.g. "references", where an empty block is used instead.)

remittanceInformation existance should be tested before

abraflexi-raiffeisenbank/src/AbraFlexi/RaiffeisenBank/Transactor.php

Line 95 in 4efcb4b

if (property_exists($transactionData->entryDetails->transactionDetails->remittanceInformation, 'creditorReferenceInformation')) {

PHP Warning: Undefined property: stdClass::$remittanceInformation in /usr/share/abraflexi-raiffeisenbank/RaiffeisenBank/Transactor.php on line 96
PHP Fatal error: Uncaught TypeError: property_exists(): Argument #1 ($object_or_class) must be of type object|string, null given in /usr/share/abraflexi-raiffeisenbank/RaiffeisenBank/Transactor.php:96

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.