Code Monkey home page Code Monkey logo

gitlab-ci-runner-win's People

Contributors

asimontsev avatar burstaholic avatar fvicente avatar haraguroicha avatar icedwater avatar rjeczalik avatar samlebarbare avatar trmanderson avatar virtualmarc avatar yurigoro avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

gitlab-ci-runner-win's Issues

Does not report runner failure due to exceptions

I'm seeing what I believe is the build thread crashing with an exception (System.IO.PathTooLongException in this case), and the GitLab CI Build page simply shows the build as 'pending' forever, never realizing that it has failed.

Error while building with Visual Studio Community 2015

Hello,
I tried to compile using Visual Studio 2015 with Windows 8.1 Pro. The binaries are created.

1>------ Rebuild All started: Project: gitlab-ci-runner, Configuration: Debug Any CPU ------
1>  gitlab-ci-runner -> C:\Users\sso\Downloads\gitlab-ci-runner-win-master\gitlab-ci-runner\bin\Debug\gitlab-ci-runner.exe
2>------ Rebuild All started: Project: runner.Build.success.test, Configuration: Debug Any CPU ------
2>C:\Program Files (x86)\MSBuild\14.0\bin\Microsoft.Common.CurrentVersion.targets(1819,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "ServiceStack.Text". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.
2>  runner.Build.success.test -> C:\Users\sso\Downloads\gitlab-ci-runner-win-master\runner.Build.success.test\bin\Debug\runner.Build.success.test.dll
========== Rebuild All: 2 succeeded, 0 failed, 0 skipped ==========

Then I run the application, located in gitlab-ci-runner\bin\Debug.
When I enter my CI URL, I get the following message.

Exception non gérée : System.ComponentModel.Win32Exception: Le fichier spécifié est introuvable
   à System.Diagnostics.Process.StartWithShellExecuteEx(ProcessStartInfo startInfo)
   à gitlab_ci_runner.helper.SSHKey.generateKeypair() dans C:\Users\sso\Downloads\gitlab-ci-runner-win-master\gitlab-ci-runner\helper\SSHKey.cs:ligne 33
   à gitlab_ci_runner.setup.Setup.run() dans C:\Users\sso\Downloads\gitlab-ci-runner-win-master\gitlab-ci-runner\setup\Setup.cs:ligne 32
   à gitlab_ci_runner.Program.Main(String[] args) dans C:\Users\sso\Downloads\gitlab-ci-runner-win-master\gitlab-ci-runner\Program.cs:ligne 37

Any idea?

build output is not cleared

Hi,

I'm unsure if this is an issue, and if it is i'm not sure if it is an issue of the windows runner or gitlab-ci.

In my setup:

  • master (today) gitlab-ci-runner-win build with VS2012 on Windows 7 x64
  • GitLab CI 4.3.0.pre f1f3353

It appears that the output is not cleared after/before run of the cmds.

That means I can see the output of commit A in the output of commit B which was build
directly after commit A on the same runner.
(I hope its clear what I mean ^^)

I will check the sources of the runner if I can spot something, but would be cool
if someone can confirm its actually an issue or wanted behavior.

Greetz

Different script handling from standard runner breaks some scripts

From the GitLab CI Project Settings page:

All lines will be concatenated in one file and executed. 
If you change the working directory or the environment in one line - it will affect the next lines too

Since the Windows runner executes each command in a new shell, this guarantee is broken, making complex build scripts rather more difficult to use.

update for compatibility with gitlab-ci 5.0

Gitlab CI 5.0+ is said to require the official runner at version 5+.

If necessary, this runner should be upgraded to be compatible with this new version, as the protocol may have seen some changes.

There's a shiny new changelog for the runner, but other things may have changed.

support git submodules

Hi,

Me again... :)

I have a repo with submodules.
By adding "--recursive" to the git clone command those get checked out automatically.
IMHO would make sense to add this in the repo.

Missing Timeout

Commands should have a timeout.

Official runner does a timeout after 7200sec. (Maybe this will be taken from the Coordinator at a later state, missing API?).

This should also be added here!

Runner deletes content of the junction points (directory links)

Rare thing - but I got a setup where sources tree contains links (junctions) to external libraries. And when Build.DeleteDirectory() is called it steps into junction and attempts to remove content there which is definitely bad thing.

Replacing the whole content of DeleteDirectory with

Directory.Delete(target_dir, true);

fixes the issue. So the question is - are there any reasons to not use the default recursive implementation of Directory.Delete which treats junctions correctly?

Directory link can be created with

mklink /j target source

" in Parameters get escaped

Calling a command with " in parameters does escape "

e.g. running:
compile.bat "name of solution.sln"

in compile.bat you get 1 parameter:
"name of solution.sln"

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.