vijaybarve / mygbif Goto Github PK

Hi Vijay,

Looking good for the most part. A few issues.
For now, remove the \dontrun commands around your examples. It's good to add those in for examples that use the internet just before you submit to CRAN, since network access shouldn't be required to pass check. However, leave it out for now to make sure check will run all the examples. I removed them and ran check, I get the following error:

Running examples in 'mygbif-Ex.R' failed
The error most likely occurred in:

> assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: gbifcount
> ### Title: gbifcount - Description
> ### Aliases: gbifcount
> 
> ### ** Examples
> 
> gbifcount('Graphium *')
Space required after the Public Identifier
SystemLiteral " or ' expected
SYSTEM or PUBLIC, the URI is missing
Opening and ending tag mismatch: hr line 9 and body
Opening and ending tag mismatch: body line 4 and html
Premature end of data in tag html line 2
Error: 1: Space required after the Public Identifier
2: SystemLiteral " or ' expected
3: SYSTEM or PUBLIC, the URI is missing
4: Opening and ending tag mismatch: hr line 9 and body
5: Opening and ending tag mismatch: body line 4 and html
6: Premature end of data in tag html line 2
Execution halted
Error: Command failed (1)

Please fix (and make sure all examples run with check).

Minor -- but I think you want license to be CC0 (with the numeral 0 at the end, CC by itself is not a recognized license).

Good work getting the package rolling on github, getting documentation set up, and writing your functions. This is a great start.

Cheers.

" I could not set license to CC0 it kept on giving me warning so changed it to BSD for the time being. "

Could you figure out how to set it CC0 and allow it to pass check() without warnings?