The tubes2_oop from vierimansyl

tubes2_oop's People

Contributors

Watchers

tubes2_oop's Issues

Potential Bug

I have found a potential bug, hope this can help:

Tubes2_OOP/src/main/java/com/aetherwars/model/Character.java

Lines 58 to 61 in 631b76f

    
           public void addExp(int exp) { 
        
               this.exp += exp; 
        
               levelUp(); 
        
           }

Tubes2_OOP/src/main/java/com/aetherwars/model/Character.java

Lines 104 to 107 in 631b76f

    
           if (target.currHealth == 0) { 
        
               exp += target.level; 
        
               levelUp(); 
        
           }

There is a possibility of multiple level ups. For example, this may happen when a Level 1 Character defeating a Level 10 Character and earning 10 experience points. I think this is not handled yet as the levelUp function only increases a character's level by 1.

This issue is only a suggestion. You may argue with it (not all the suggestions are true), challenge it, or come up with another idea yourself.

Code Structure

I think it will be better if classes that extend other classes are placed into subfolders. For example, LevelSpell, Morph, Potion and Swap can be placed in one "Spells" subfolder. This will increase project searchability by reducing the number of files in the "model" folder.

This issue is only a suggestion. You may argue with it (not all the suggestions are true), challenge it, or come up with another idea yourself.

Recommend Projects

vierimansyl / tubes2_oop Goto Github PK

tubes2_oop's People

Contributors

Watchers

Forkers

tubes2_oop's Issues

Potential Bug

Code Structure

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	if (target.currHealth == 0) {
	exp += target.level;
	levelUp();
	}