videojs / videojs-errors Goto Github PK

Description

Briefly describe the issue.
The newest release throws a webpack error. The result is a non uglified js file so its much larger in file size.

ERROR in p_videojs.js from UglifyJs
Unexpected token: name (monitor) [p_videojs.js:49757,6]

Steps to reproduce

"./node_modules/.bin/webpack -p --config webpack.config.js"

the -p flag is important. Make sure not using any extra uglifer plugin. See package.json below.

"devDependencies": {
    "babel-core": "^6.24.1",
    "babel-loader": "^6.4.1",
    "babel-plugin-transform-class-properties": "^6.24.1",
    "babel-plugin-transform-object-assign": "^6.22.0",
    "babel-plugin-transform-object-rest-spread": "^6.26.0",
    "babel-plugin-transform-react-inline-elements": "^6.22.0",
    "babel-preset-env": "^1.6.1",
    "babel-preset-es2016": "^6.24.1",
    "babel-preset-react": "^6.22.0",
    "classnames": "^2.2.5",
    "css-loader": "^0.28.4",
    "extract-text-webpack-plugin": "^2.1.2",
    "node-sass": "^4.7.2",
    "promise-polyfill": "6.0.2",
    "sass-loader": "^6.0.6",
    "style-loader": "^0.18.2",
    "url-loader": "^0.6.2",
    "webpack": "^3.10.0"
  },
  "dependencies": {
    "can-autoplay": "^3.0.0",
    "es6-promise": "^4.1.1",
    "global": "^4.3.2",
    "ie-array-find-polyfill": "^1.1.0",
    "is-empty": "^1.2.0",
    "query-string": "^5.1.0",
    "react": "^15.4.2",
    "react-dom": "^15.6.2",
    "video.js": "^6.9.0",
    "videojs-contrib-ads": "^6.2.0",
    "videojs-contrib-hls": "^5.14.1",
    "videojs-errors": "4.1.0",
    "videojs-flash": "^2.1.0",
    "videojs-hotkeys": "^0.2.21",
    "videojs-ima": "^1.3.0"
  }

Webpack config:

var ExtractTextPlugin = require('extract-text-webpack-plugin');

module.exports = {
  context: __dirname + "/src",
  entry: "./index.js",
  module: {
    loaders: [
      {
        test: /\.js$/,
        exclude: /node_modules/,
        loader: 'babel-loader?presets[]=es2016,presets[]=react'
      },
      {
        test: /\.scss$/,
        loader: ExtractTextPlugin.extract({
          fallback: 'style-loader', // The backup style loader
          use: 'css-loader?sourceMap!sass-loader?sourceMap'
        })
      },
      {
        test: /\.(png|jpg|gif|svg)$/,
        loader: 'url-loader'
      }
    ],
  },
  output: {
    filename: "p_videojs.js",
    path: __dirname + "/dist",
  },
  plugins: [
    new ExtractTextPlugin('p_videojs.css')
  ],
}

babel.rc

{
  "compact": true,
  "presets": [
    ["env", {
      "targets": {
        "browsers": ["last 2 versions", "safari >= 7"]
      }
    }]
  ],
  "plugins": [
    "transform-object-assign",
    "transform-class-properties",
    "transform-react-inline-elements",
    "transform-object-rest-spread"
  ]
}

Results

Expected

Would compile and uglifiy as normal.

Actual

Throws error.

v4.1.0 works fine.

Description

Briefly describe the issue.
When we cast our stream (chromecast).
If we have included the errors plugin, the timeout is not satisfied for live HLS content.
The plugin is calling triggerReady(). Thats call seems to cause the problem if we pause on a break before that, the timeout is not started.

Looking to know how I could prevent thet timeout, reset it, or satisfy it.

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

1. Include this plugin
2. include this plugin and view issue: silvermine/videojs-chromecast#28

Results

Expected

Video cast as normal: 'vjs-is-waiting' or stall to stop.

Actual

Videois casts and pauses after 45 seconds.

Error output

If there are any errors at all, please include them here.

Additional Information

Please include any additional information necessary here. Including the following:

versions

videojs

what version of videojs does this occur with?
"version": "6.12.1",

Can reproduce here: https://dev.pac-12.com/live/pac-12-live-press-conferences

it don't work with the latest version of video.js (5.0+), please support it

I'm trying to set custom message for this video.js error and have no success:
VIDEOJS: ERROR: (CODE:0 MEDIA_ERR_CUSTOM) FLASH: rtmpconnectfailure

video.errors({
    errors: {
        0: {
            headline: 'This is an override for the generic MEDIA_ERR_DECODE',
            message: 'This is a custom error message'
        }
    }
});

The devDependency rollup was updated from 0.67.3 to 0.67.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Hello,

I m interested to use this plugin but I don't know how to built the error.css and error.js files.

Could it be possible to ship the ready made files in the zip?

thanks

See https://github.com/brightcove/videojs-errors/blob/b3498952c5c71c6064edc08deebbdca23783ec70/src/videojs.errors.js#L164

The devDependency rollup was updated from 1.18.0 to 1.19.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Would require some styling to work.

hi

and the corresponding css file arent included in the master.

I would like to use your plugin (v3.0.3) but after downloading the zip and opening it, I could not find the js/css files to include in the page. How can I get the latest files of this great plugin?

The devDependency rollup was updated from 1.9.2 to 1.9.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Description

Cannot use 'in' operator to search for 'default' in undefined. How to fix it?

Description

v4.1.1 is not transpiling es6 syntax correctly. Specifically, arrow functions are not being transpiled. Not an issue in v4.1.0

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

1. git clone [email protected]:brightcove/videojs-errors.git

2. cd videojs-errors

3. npm i

4. npm run build

5. grep "=>" ./dist/videojs-errors.es.js

6. Observe that there are remaining arrow functions.

7. git fetch --all --tags --prune

8. git checkout tags/v4.1.0 -b v410

9. npm i

10. npm build

11. grep "=>" ./dist/videojs-errors.es.js

12. Observe that there no are remaining arrow functions.

Results

Expected

Expected to see es5 friendly syntax.

Actual

Expected to see es6 syntax, specifically arrow functions.

Error output

If there are any errors at all, please include them here.

Additional Information

Please include any additional information necessary here. Including the following:

versions

videojs

^6.8.0 || ^7.0.0

browsers

what browser are affected?
cli only.

OSes

what platforms (operating systems and devices) are affected?
OSX 10.13.3

plugins

are any videojs plugins being used on the page? If so, please list them below.
No.

Description

The videojs-errors plugin is not registered correctly when using with videojs 6 and npm.
The reason is the package json: "video.js": "^5.19.2".

This leads npm to download an own videojs dependency for this plugin that is be used.
So videojs 5 gets imported too and videojs 6 doesn't know the errors plugin.

Steps to reproduce

just try:

import videojs from 'video.js';
import errors from 'videojs-errors';

videojs.getPlugin('errors')  //undefined

Results

Expected

plugin works properly.

Actual

videojs-errors is not registered as a plugin and videojs 5 get additionally added to bundle.

versions

videojs: 6.8.0
videojs-error: 3.1.0

Description

Hello!
My videos that use geoblock return a 403 error, however, with 'mediaerror' it always gets in error 4. I would like it to get into the PLAYER_ERR_GEO_RESTRICTED error. How could I do that?

versions

videojs

v7.7.5

plugins

videojs-errors
v4.3.2

Description

plugin initializing with video js options is not working.

Steps to reproduce

just do:

import videojs from 'video.js';
import 'videojs-errors';

const options = {
    plugins: {
        errors: { 
            errors: {
                FOO: {
                    headline: 'headline',
                    message: 'This is a custom error message'
                }
            }
        }
    }
};

const player = videojs(element, options, () => {

    setTimeout(() => {
        console.log(player.errors.getAll()); // contains FOO error

        player.error({code: 'FOO'}); // empty error screen appears
        
    },2000);
});

Results

Expected

custom error should be visible

Actual

error screen appears empty (except a white X)

Error output

Additional Information

videojs

6.8

errors plugin

4.1

The devDependency karma was updated from 3.1.1 to 3.1.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

karma is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

See the question - do I need to include it myself - or does videojs magically include it itself, and if so, what path should it have ?

The devDependency conventional-changelog-cli was updated from 2.0.5 to 2.0.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

conventional-changelog-cli is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency rollup was updated from 1.27.6 to 1.27.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I'm working on a plugin that allows you to record audio/video using video.js. When the user requests access to the system's microphone using getUserMedia there's a chance he denies access and this throws an error message. I'd like to use your plugin for this but running into a problem;

when loading the plugin it immediately shows a PLAYER_ERR_NO_SRC error. This is expected because you're working without a source when recording locally. Is there a way to disable this error message (or all of them)?

Description

if I try to import a language file I got ReferenceError: videojs is not defined

so any lang file should have an import statement befor videojs to fix this.
besides that, a work around could be to provide the pure json files in videojs build.
this also would be great to extend a language during project build.

Steps to reproduce

just do

import videojs from 'video.js';
import 'videojs-errors';

import 'videojs-errors/dist/lang/de';

Results

Expected

should work as expected

Actual

it breaks

Additional Information

videojs: 6.8.0