vjs-has-started not updated with 4.6 about videojs-contrib-hls HOT 20 CLOSED

We'll look into this once we get the hls-tech (#62) work merged in.

from videojs-contrib-hls.

@gkatsev i can still observe the same after upgrading to the merged #62

from videojs-contrib-hls.

when I downgrade videojs to 4.5.1 then it works for me. looks like others have similar problems (videojs/video.js#1226). I consider it more likely to be a videojs rather than a hls-contrib issue, but would appreciate you looking into it anyway

from videojs-contrib-hls.

We are looking into it. It is most likely a video-js-swf issue.

from videojs-contrib-hls.

This should be fixed in in #66.

from videojs-contrib-hls.

The video controls still don't show up for me after pressing the play button (Google Chrome). My setup:

• video.js at master
• video-js-swf at master
• videojs-contrib-media-sources with videojs/videojs-contrib-media-sources#11 merged
• videojs-contrib-hls with #66 merged

from videojs-contrib-hls.

@mkilling you need videojs/video-js-swf#93 as well

from videojs-contrib-hls.

@gkatsev Wasn't videojs/video-js-swf#93 already merged into videojs/video-js-swf master?

from videojs-contrib-hls.

@mkilling so it was. I forgot. Hm... it was definitely working for us yesterday...
Is it giving you any errors? Also, are you loading it properly as a tech now?

from videojs-contrib-hls.

No errors in the console...

<video id="video-player" class="video-js vjs-default-skin" controls preload="auto" width="620px" height="465px" poster="https://my_thumbnail">
    <source type="application/x-mpegURL" src="http://s3.amazonaws.com/my_bucket/my_video">
</video>

I initialize the player like this:

videojs("video-player", { playbackRates: [1, 1.5, 2, 3], techOrder: ['html5', 'hls', 'flash'] });

from videojs-contrib-hls.

Is it playing otherwise?

from videojs-contrib-hls.

Yes, the video is playing. Only the large play button in the top left corner does not disappear and the video controls don't show up. It works with the same setup when pointing it to an mp4 file instead of the m3u8

from videojs-contrib-hls.

Hm... I guess we didn't fix this it fully. Thanks for reporting.

from videojs-contrib-hls.

Turns out I didn't specify the right .swf file. It works for me now. Sorry for the confusion.

from videojs-contrib-hls.

@mkilling No worries. So, it works as expected now?

from videojs-contrib-hls.

Yes it does. Controls show up and everything is fine ;-)

from videojs-contrib-hls.

Awesome, thanks for verifying!

from videojs-contrib-hls.

I can verify it is working here as well. Any chance to get all the stuff merged and released? Right now our next production deployment will contain unmerged and unrelease changes and I want to avoid maintenance nightmares :-) thanks!

from videojs-contrib-hls.

It will get merged in this week. Hopefully, released this week as well.

from videojs-contrib-hls.

Updates have been released. Closing now as it should be fixed, but feel free to reopen and comment if there are still problems.

from videojs-contrib-hls.