Address issue found in JavaScript-Files/begin_round.js [Opened by bitHound]

bitHound discovered 1 ComplexFunction in JavaScript-Files/begin_round.js. For details go to bitHound.

I think we should shorten this function! Any ideas @Goredbirds?

Also I finished adding all the players!

Re-styling

I am going to add so more styling to the pages.

Bugs

There are a lot of since that last pull request so lets fix all those bugs.

Here are some of them:

HTML

Change JS links
Put in new ones
Delete the old buttons

JS

None -

CSS

None -

The ones that have none are probably going to change once we complete the ones for HTML because since they are not linked to anything, they will not show any bugs on the page. Any questions? Please comment below.

Bug!

I found a new bug @GoRedbirds! You can not earn any money anymore! We need to fix that right away!

Test ticket from Code Climate

GitHub Pages

Right now our project on GitHub Pages does not work. @GoRedbirds Do you have any ideas on how to make this work?

2-4 player

What about we start on the 2-4 player update(@Goredbirds)?

Max workers to buy

What if when you buy workers it automatically has the max number of workers in the prompt! Then you don't have to write it in every time.

Buttons(jQuery)

Re-Styling buttons:

Making buttons look better

Schedule:

(If one "check works" works than terminate 💯 🥇 👍 ).

If none work, report to @GoRedbirds and find other solutions.

Adding new players

It takes a long time to add another player. I am going to change that.

JS update

I am going to be adding functions so your stats will be shown on the game page.

Address issue found in script.js [Opened by bitHound]

bitHound discovered 16 LintIssues in script.js. For details go to bitHound.

I'm going to be working on fixing these bugs right now.

Adding play pause buttons

the next thing I need to work on is adding a play/pause button to this repository.

Test ticket from Code Climate

Fix 9 Duplication issues in multiple files

CodeFactor found multiple issues last seen at 9074bb9:

Duplicate Code

New People

Any new changes for adding new people? Add it here.

Tax bug

https://github.com/StevenCopeland/Stores/blob/66b58d4b9c71681b64c50f8b31059a57e15056d4/script.js#L105-L120

Some people are definitely not taxed. We need to fix this bug.

Code Duplication

There have been a lot of duplication errors. Just a few are:

JavaScript-Files\begin_round1.js:102-128
JavaScript-Files\begin_round2.js:102-128

And I would like to fix that. So what if all the functions were global but were called in each function.
Of course you would have to have parameters so you would be able to call them on different players each time, but that would be able to do.
What do you think @GoRedbirds? I will begin working on the upgrade on a new branch.

Steps

Upgraded workers

We should add upgraded workers because right now it all depends on how many workers you can buy. If you have more money then you are almost certain to win. But if you add upgraded workers then if you are behind then you will be able to get ahead again.

Bugs

I have been finding a lot of bugs for Stores. For two play version, player ai2 can't buy workers. I mean, ai2 earns money, it just doesn't show the amount of workers.

vic-st / stores Goto Github PK

stores's People

Contributors

Watchers

Forkers

stores's Issues