vibraneur-capstone / vape-sensor-inventory Goto Github PK

This is a snapshot of what we have in the databse. It looks like whenever we are adding a sensor to bearing, it just does a simple append without deduplicate..
"sensorsId": [
"5e4c06b3df9931ea80aea288",
"5e4c06b3df9931ea80aea288",
"5e4c06b3df9931ea80aea288",
"5e4c06b3df9931ea80aea288",
"5e4c06b3df9931ea80aea288",
"5e4c06b3df9931ea80aea288",

Currently if query a bearing that does not exist in the databse, the api would return 500. Ideally the api should return 400, since it is likely the user's fault:
Suggested action is to add try block to catch ModelDoesNotExist Exceptions.
See Line 18 (return Bearing.objects.get(id=id)) in bearing_info.py

Just a heads - these are sufficient to access your database on Atlas:

Tested by inserting a doc to a new db and collection:

MongoDB Enterprise cluster-vape-sensor-inventory-shard-0:PRIMARY> db.getSiblingDB("hello")["world"].find()
{ "_id" : ObjectId("5e3cb4d666f9fa4df195e6c2"), "example" : "doc" }

Doesn't look like the database itself has been used for much yet, but these credentials should be rotated as soon as is reasonable.

In line 30 (post_new_bearing function) of bearing_info_controller.py

This function tries to access tags and sensorId field from body. If these fields do not exist, the API will likely throw 500 errors when it clearly is the user's fault. We should practice defensive coding for this part. Although, tags is an optional field. If tags is not found in body a default {} dict should be used.