vi / tokio-listener Goto Github PK

As described in https://mgdm.net/weblog/systemd-socket-activation/, it's possible to receive multiple sockets, and they can have names attached.

This can be used to have multiple .socket files (with different FileDescriptorName= values).

For example, one socket could be used for http, and another one for https connections.

Hi,

thank you for this convenient library which promises to very conveniently solve one of my problems :P
While looking through this library, I stumbled accross examples/clap_axum.rs, which seems to be incompatible with axum >= 0.7 and/or hyper >= 1.0 to me:

Hyper 1.0 apparently dropped the hyper::Server interface, and axum followed suit as it just reexported hyper::Server as axum::Server but instead provides an axum::serve interface itself, which, however, is spcifically tied to TcpListeners.

Axum has since also updated their examples (including the unix domain socket example which is probably most relevant to tokio-listeners usage), effectively replicating hyper's previous Server functionality by a custom accept loop.
I believe (without too much certainty, I'm quite new to using axum) that this is now also required for tokio-listener, as it does not offer the TcpListener interface. Furthermore, probably a mechanism akin to what is already implemented for the tonic010 feature might be required to correctly attribute the correct ConnectionInfo type/have a custom ListenerConnectInfo compatible with Router::into_make_service_with_connect_info for situations where connection info is of interest.

Is my assessment correct? Is there any clever way of using tokio-listener together with axum >= 0.7 without too much hassle? What is the recommended way as of now? What would examples/clap_axum.rs look like nowadays?

Thank you for providing this library in the first place, and also thank you for taking the time to read this bug report :) (Furthermore: I'm sorry if I've missed something obvious and thus wasted some of your time).
~ Simon