vhotspur / pcut Goto Github PK

Both of these tests checks how PCUT behaves when test is unexpectedly aborted (e.g. during NULL pointer dereference). To achieve this, they intentionally access *p where p == NULL. However, this is undefined behaviour and Clang optimizations causes that the dereference returns 0 (while GCC-compiled program ends with SEGFAULT). See What Every C Programmer Should Know About Undefined Behavior for more details. Note that this happens only with -O3: with -O0 the compiled program behaves the same as GCC-compiled one does.

Fixing ought to be easy: the tests shall explicitly call abort() or its equivalent.

I'm gonna just be lazy and link the offending commit :)

int test_foo;

PCUT_TEST(foo)
{
...
}

fails to compile because foo is mangled to test_foo. Perhaps test case identifiers should be mangled to something that the programmer is less likely to use accidentally, such as _test_xxx or _pcut_xxx, for example.

Pcut creates temporary files in the current directory with its homebrew code, either in generic.c or helenos.c. On HelenOS if / is full or if the test is run with WD set to a non-writable directory (e.g. /loc), PCUT will fail to create temporary file for every test.

Suggestion: How about tmpfile() on HelenOS and tmpnam() on generic?