veroandreo / i.landsat Goto Github PK

Landsat Collection 1 data comes in 3 tiers: Real Time, Tier 1 and Tier 2. From those, Tier 1 (T1) is regarded as the best one for time series analysis. Tier 2, instead, has less accurate orbital information (specific to older Landsat sensors), significant cloud cover, insufficient ground control, or other factors.

This information is stored in the filename, esp in the displayId field. It would be cool to add a parameter to filter results by tier.

Are you sure that you have to print() it?

Since the module is mostly recycled from i.sentinel.import, it suffers from the same problem when importing into latlong locations.

One solution could be to add a condition that if the target location is latlong, the module to use should be r.import with resolution_value = estimated as opposed to current behavior resolution_value = value where value is read from metadata in which it is expressed in meters.

See OSGeo/grass-addons#84

Imports of landsatexplore should be moved from here:

to after the parser (and before main is run) here:

Otherwise the manuals will not build on the built server (and the module will be unavailable on Windows).
It is also an advantage to wrap the import in a try-except-statement and give users a proper error message, instead of a traceback...

See e.g.
https://github.com/OSGeo/grass-addons/blob/98ca4366a03193e998c467c55fb095ade9d8b426/grass7/raster/r.mregression.series/r.mregression.series.py#L279
as an example.

These two lines:

Only a little relevant detail though...

Stumbled over this one just now:
https://github.com/NikosAlexandris/i.landsat.import
Maybe you can coordinate with @NikosAlexandris?

In the case of downloading and importing a time series of landsat data, it would be great to have an output with the file to register such scenes in the temporal database.

I suggest to move this call later after you check if user and password are set so you have just a place where you call the function

should be replaced with

return (info['w'], info['s'], info['e'], info['n'])

in this way you return a tuple with the four value

i.landsat.import is now a very simple module to import all Landsat bands from the input or unzip_dir directories. More options should be added to allow to select which bands to import or which .tar.gz files to unzip (e.g. only those of a certain path an row).

Similar to get_bb() and because right now, it does not seem to work properly in the landsatxplore library itself (see this issue), it would be nice to also have a function to retrieve central coordinates of the vector extent or region. In this way, we can pass those coordinates to the longitude and latitude parameters in the api.

Shall we also expose them as parameters of the module? What do you think @lucadelu?

Something like:
end=today
start=today-60

Setting -l should print the scenes found, not setting it should download all of them. Using an id or a list of ids is a separate option.

Once import is done, list of .tif files should be removed

This would probably mean to create a table with scenes found, so then I can sort it by columns

Will this fail with invalid IDs