verizon / funnel Goto Github PK

Prefer seperate params for the jvm metrics and sigar metrics, as not everyone will want to run sigar.

https://github.com/oncue/funnel/blob/gh-pages/index.html#L61 - Ki{a,}bana

Factor out the pushChanges step into the build script so its the last thing that happens in the travis file.

• too much assumption about the machine type, this should be more flexible. consider providing the configuration location with a -D command line or an env var.

https://bintray.com/oncue/releases/funnel#files/oncue/funnel/core_2.11

https://github.com/oncue/funnel/blob/gh-pages/index.html#L96 - `<img src="/funnel/img/time-periods.jpg" alt="image />1

we are passing the Seq type around in a bunch of places. This type is an abomination we should avoid, since Seq doesn't tell us if the set is bounded, and doens't tell us if the set is immutable. There are, in fact, places in our code where we end up with a mutable Buffer. Even worse though is that there are places that we are calling .length on a List. We should probably just converge on Vector all these places.

During a load test we uncovered a situation where an application may become blocked by the funnel agent.

The working theory is as follows:

1. The flask becomes very slow due to very frequent key queries (this has since been fixed)
2. The agent is performing blocking writes to the stream requests. Since the consumer is not consuming, they end up essentially blocked.
3. The operation to add a metric performs a compareAndSet, which blocks the current thread while waiting for reads to complete.

Copying a large stack trace here:

stack_trace.txt