Code Monkey home page Code Monkey logo

Comments (8)

igorklopov avatar igorklopov commented on May 22, 2024 5

@simast Yes!

from pkg.

dvlsg avatar dvlsg commented on May 22, 2024 1

If this is using the same snapshotting functionality that nwjs is utilizing, then it's possible that the performance issues have been improved greatly by the v8 team. Might just be part of using ignition / turbofan?

from pkg.

igorklopov avatar igorklopov commented on May 22, 2024 1

@dvlsg please try passing --options ignition,turbo,turbo-from-bytecode to your pkg command line.

from pkg.

simast avatar simast commented on May 22, 2024 1

@igorklopov That's interesting, could you elaborate more? Does that mean with ignition and turbofan enabled (which is enabled by default from v8 5.9) - there won't be any performance drawbacks and the compiled code will be optimised during runtime?

from pkg.

firrae avatar firrae commented on May 22, 2024 1

Hi there,

So I added --options ignition,turbo,turbo-from-bytecode to the build I just did and got the following error:

buffer.js:12
    super(arg1, arg2, arg3);
    ^

ReferenceError: this is not defined
    at FastBuffer (buffer.js:12:5)
    at createUnsafeBuffer (buffer.js:38:10)
    at allocate (buffer.js:190:12)
    at Function.Buffer.allocUnsafe (buffer.js:153:10)
    at Function.Buffer.concat (buffer.js:322:23)
    at Socket.<anonymous> ([eval]:5:20)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:189:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at Socket.Readable.push (_stream_readable.js:134:10)
    at Pipe.onread (net.js:551:20)
> Error! Error: Was not able to compile for '{"nodeRange":"node7","platform":"linux","arch":"x64","output":"/Users/steven.lambe/iot/index-linux","forceBuild":false,"fabricator":{"nodeRange":"node7","platform":"macos","arch":"x64","forceBuild":false,"binaryPath":"/Users/steven.lambe/.pkg-cache/v1.9/fetched-v7.6.0-macos-x64"},"binaryPath":"/Users/steven.lambe/.pkg-cache/v1.9/fetched-v7.6.0-linux-x64","slash":"/"}'
    at Socket.<anonymous> (/usr/local/lib/node_modules/pkg/lib-es5/producer.js:46:25)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at onwriteError (_stream_writable.js:341:10)
    at onwrite (_stream_writable.js:359:5)
    at fireErrorCallbacks (net.js:480:13)
    at Socket._destroy (net.js:521:3)
    at WriteWrap.afterWrite [as oncomplete] (net.js:815:10)

Once I removed turbo-from-bytecode though it seems to work. Am I missing something?

Building on Mac, targeting Mac, Linux, and Windows x64 with Node 7.

from pkg.

rmharrison avatar rmharrison commented on May 22, 2024

Add Pros of pkg (and comparison to nexe) from #42 to README?

@markelog: NB: enclosejs.com is dead as of 3 May 2017

from pkg.

igorklopov avatar igorklopov commented on May 22, 2024

It just proves that flagged features are unstable. I will look into it later. However we should probably wait for node.js 8 with stable Ignition/TurboFan https://www.youtube.com/watch?v=YTAFT2blJDo

from pkg.

leerob avatar leerob commented on May 22, 2024

Closing this as stale 🙏 Thank you anyway! If someone from the community would like to contribute back and mention pros/cons versus current solutions in 2021, I can take a look.

from pkg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.